Revert 168908 "Col width is not honored when dynamically updated..."

Revert 168908 "Col width is not honored when dynamically updated..."

> Col width is not honored when dynamically updated and it would not make table narrower
> 
> Increasing the table width by increasing the colgroup width was working
> but decreasing the table width by decreasing the colgroup width is not working.
> 
> When colgroup width is defined table cell should adjust according to that.
> On decreasing colgroup width the cells maxPreferredLogicalWidth was
> still set to the earlier value. Setting the setPreferredLogicalWidthsDirty
> to true so that cells pref width is calculated again.
> 
> I already landed this patch on webkit. Just modified the layout test file and fixed build errors.
> http://trac.webkit.org/changeset/162334.
> 
> R=jchaffraix@chromium.org
> BUG=340252
> 
> Review URL: https://codereview.chromium.org/151993004

TBR=k.gurpreet@samsung.com

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169022

[inferno, 2014-03-12 15:26:43]

Committed patchset #1 manually as r169022.

[Gurpreet, 2014-03-13 03:57:15]

On 2014/03/12 15:26:43, inferno wrote:
> Committed patchset #1 manually as r169022.

Why this patch has been reverted?

[inferno, 2014-03-13 04:09:35]

On 2014/03/13 03:57:15, Gurpreet wrote:
> On 2014/03/12 15:26:43, inferno wrote:
> > Committed patchset #1 manually as r169022.
> 
> Why this patch has been reverted?

i cced you on https://code.google.com/p/chromium/issues/detail?id=351729. It
causes many regression on ClusterFuzz and introduced use-after free crashes.

[Gurpreet, 2014-03-13 08:44:14]

On 2014/03/13 04:09:35, inferno wrote:
> On 2014/03/13 03:57:15, Gurpreet wrote:
> > On 2014/03/12 15:26:43, inferno wrote:
> > > Committed patchset #1 manually as r169022.
> > 
> > Why this patch has been reverted?
> 
> i cced you on https://code.google.com/p/chromium/issues/detail?id=351729. It
> causes many regression on ClusterFuzz and introduced use-after free crashes.

I am not able to download the reduced test cases to check for the crash.

[Gurpreet, 2014-03-13 13:09:31]

On 2014/03/13 08:44:14, Gurpreet wrote:
> On 2014/03/13 04:09:35, inferno wrote:
> > On 2014/03/13 03:57:15, Gurpreet wrote:
> > > On 2014/03/12 15:26:43, inferno wrote:
> > > > Committed patchset #1 manually as r169022.
> > > 
> > > Why this patch has been reverted?
> > 
> > i cced you on https://code.google.com/p/chromium/issues/detail?id=351729. It
> > causes many regression on ClusterFuzz and introduced use-after free crashes.
> 
> I am not able to download the reduced test cases to check for the crash.

I am not able to download the minimized Testcase it says
"You (k.gurpreet@samsung.com) are not authorized to access this page!

For access, please contact Abhishek Arya (inferno [at] chromium [dot] org).

Back
Switch account
Logout

[Gurpreet, 2014-03-18 07:13:28]

On 2014/03/13 13:09:31, Gurpreet wrote:
> On 2014/03/13 08:44:14, Gurpreet wrote:
> > On 2014/03/13 04:09:35, inferno wrote:
> > > On 2014/03/13 03:57:15, Gurpreet wrote:
> > > > On 2014/03/12 15:26:43, inferno wrote:
> > > > > Committed patchset #1 manually as r169022.
> > > > 
> > > > Why this patch has been reverted?
> > > 
> > > i cced you on https://code.google.com/p/chromium/issues/detail?id=351729.
It
> > > causes many regression on ClusterFuzz and introduced use-after free
crashes.
> > 
> > I am not able to download the reduced test cases to check for the crash.
> 
> I am not able to download the minimized Testcase it says
> "You (mailto:k.gurpreet@samsung.com) are not authorized to access this page!
> 
> For access, please contact Abhishek Arya (inferno [at] chromium [dot] org).
> 
> Back
> Switch account
> Logout

The fix for the crash has been submitted in
https://bugs.webkit.org/show_bug.cgi?id=129561. We can submit this patch along
with https://codereview.chromium.org/151993004/ patch and this would solve the
crash. Else separately can submit 2 patches. Please suggest.

[aarya, 2014-03-18 14:51:40]

On 2014/03/18 07:13:28, Gurpreet wrote:
> On 2014/03/13 13:09:31, Gurpreet wrote:
> > On 2014/03/13 08:44:14, Gurpreet wrote:
> > > On 2014/03/13 04:09:35, inferno wrote:
> > > > On 2014/03/13 03:57:15, Gurpreet wrote:
> > > > > On 2014/03/12 15:26:43, inferno wrote:
> > > > > > Committed patchset #1 manually as r169022.
> > > > > 
> > > > > Why this patch has been reverted?
> > > > 
> > > > i cced you on
https://code.google.com/p/chromium/issues/detail?id=351729.
> It
> > > > causes many regression on ClusterFuzz and introduced use-after free
> crashes.
> > > 
> > > I am not able to download the reduced test cases to check for the crash.
> > 
> > I am not able to download the minimized Testcase it says
> > "You (mailto:k.gurpreet@samsung.com) are not authorized to access this page!
> > 
> > For access, please contact Abhishek Arya (inferno [at] chromium [dot] org).
> > 
> > Back
> > Switch account
> > Logout
> 
> The fix for the crash has been submitted in
> https://bugs.webkit.org/show_bug.cgi?id=129561. We can submit this patch along
> with https://codereview.chromium.org/151993004/ patch and this would solve the
> crash. Else separately can submit 2 patches. Please suggest.

Seperate is better. since it is easier to revert.