Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: trunk/Source/core/rendering/RenderTableCol.cpp

Issue 197013005: Revert 168908 "Col width is not honored when dynamically updated..." (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/LayoutTests/fast/table/resize-table-width-using-multiple-col-span-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/Source/core/rendering/RenderTableCol.cpp
===================================================================
--- trunk/Source/core/rendering/RenderTableCol.cpp (revision 169021)
+++ trunk/Source/core/rendering/RenderTableCol.cpp (working copy)
@@ -51,24 +51,8 @@
// If border was changed, notify table.
if (parent()) {
RenderTable* table = this->table();
- if (table && !table->selfNeedsLayout() && !table->normalChildNeedsLayout() && oldStyle && oldStyle->border() != style()->border()) {
+ if (table && !table->selfNeedsLayout() && !table->normalChildNeedsLayout() && oldStyle && oldStyle->border() != style()->border())
table->invalidateCollapsedBorders();
- } else if (oldStyle && oldStyle->logicalWidth() != style()->logicalWidth()) {
- // FIXME : setPreferredLogicalWidthsDirty is done for all cells as of now.
- // Need to find a better way so that only the cells which are changed by
- // the col width should have preferred logical widths recomputed.
- unsigned nEffCols = table->numEffCols();
- for (RenderTableSection* section = table->topSection(); section; section = table->sectionBelow(section)) {
- for (unsigned j = 0; j < nEffCols; j++) {
- for (unsigned i = 0; i < section->numRows(); i++) {
- RenderTableCell* cell = section->primaryCellAt(i, j);
- if (!cell)
- continue;
- cell->setPreferredLogicalWidthsDirty();
- }
- }
- }
- }
}
}
« no previous file with comments | « trunk/LayoutTests/fast/table/resize-table-width-using-multiple-col-span-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698