Chromium Code Reviews Chromium Code Reviews
Issue
1970073002:
Revert of Fixes use-after-free bug in QUIC. (Closed)
DescriptionRevert of Fixes use-after-free bug in QUIC. (patchset #1 id:1 of https://codereview.chromium.org/1975483003/ )
Reason for revert:
breaks M51: https://bugs.chromium.org/p/chromium/issues/detail?id=611267
Original issue's description:
> Fixes use-after-free bug in QUIC.
>
> QuicSession destructor ends up calling the QuicSpdyStream destructor, which in turn tries to access a QuicSession method via a non-owning pointer back to the session. This CL arranges for the non-owning pointer to be set to null before QuicSpdyStream destructor is called.
>
> Merge Internal CL: 120973813
>
> Creates a MockQuicSession for use in ReliableQuicStreamTest, which currently incorrectly uses a MockQuicSpdySession.
>
> The test class being fixed in this CL uses a MockQuicSpdySession, which is a QuicSpdySession, with TestStreams, which are ReliableQuicStreams. Bad things can happen since QuicSpdySession seems to freely assume that its streams are QuicSpdyStreams. Bad things do happen, but they inexplicably seem to show up only in Chromium tests.
>
> Merge Internal CL: 120989117
>
> BUG=605474
> NOTRY=true
> NOPRESUBMIT=true
> Review-Url: https://codereview.chromium.org/1932653002
> Cr-Commit-Position: refs/heads/master@{#390575}
> (cherry picked from commit 4ee9d76953f16811186942971822cf12d48db7ae)
TBR=rch@chromium.org,jri@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605474
Patch Set 1 #
Messages
Total messages: 3 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
