Issue 1969873003: Remove WebApkServiceImpl#getBroadcastPendingIntent() because it is unneeded

Issue 1969873003: Remove WebApkServiceImpl#getBroadcastPendingIntent() because it is unneeded (Closed)

Created:
4 years, 7 months ago by pkotwicz

Modified:
4 years, 7 months ago

Reviewers:
Xi Han

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove WebApkServiceImpl#getBroadcastPendingIntent() because it is unneeded BUG=609122

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -191 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java	View	1	4 chunks	+61 lines, -136 lines	0 comments	Download
M	chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/NotificationClient.java	View		3 chunks	+2 lines, -41 lines	0 comments	Download
M	chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/IWebApkApi.aidl	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImpl.java	View		2 chunks	+0 lines, -8 lines	0 comments	Download

Total messages: 7 (2 generated)

pkotwicz

Xi can you please take a look? I was not able to get a SecurityException ...

4 years, 7 months ago (2016-05-11 19:42:55 UTC) #2

Yaron

On 2016/05/11 19:55:45, Xi Han wrote: > Cool! lgtm! I'm a bit confused by this. ...

4 years, 7 months ago (2016-05-12 15:16:15 UTC) #5

pkotwicz

Xi and I tried on Android L & M on several phones. I have not ...

4 years, 7 months ago (2016-05-12 15:21:38 UTC) #6

pkotwicz

4 years, 7 months ago (2016-05-12 15:21:38 UTC) #7

Message was sent while issue was closed.

Xi and I tried on Android L & M on several phones. I have not tried on Android K
or N