Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1969723004: Add a counter and a deprecation message when navigating in an unload handler. (Closed)

Created:
4 years, 7 months ago by lfg
Modified:
4 years, 7 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, asvitkine+watch_chromium.org, blink-reviews, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a counter and a deprecation message when navigating in an unload handler. Blink intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/VfItzNe3WO0 BUG=613244 Committed: https://crrev.com/9e8d2940fd58f042dd06e60367de9b2bd478c3bd Cr-Commit-Position: refs/heads/master@{#396077}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : only count inpage navigations, as others are already blocked #

Patch Set 4 : test #

Total comments: 8

Patch Set 5 : rebase #

Patch Set 6 : move counter to dispatchUnloadEvent #

Patch Set 7 : rebase #

Patch Set 8 : rebase #

Patch Set 9 : adding line number to test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/state-restore-skip-stateless-expected.txt View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.h View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.cpp View 1 2 3 3 chunks +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 27 (12 generated)
lfg
Rick, can you take a look? Should I create a chromestatus entry for this?
4 years, 7 months ago (2016-05-13 21:33:09 UTC) #4
Rick Byers
The UseCounter LGTM, but I don't have expertise in the loader (eg. to confirm that ...
4 years, 7 months ago (2016-05-13 21:48:36 UTC) #5
Nate Chapin
Should there be a BUG= in the description? A couple of implementation questions below... https://codereview.chromium.org/1969723004/diff/60001/third_party/WebKit/Source/core/loader/FrameLoader.cpp ...
4 years, 7 months ago (2016-05-13 21:56:10 UTC) #7
Rick Byers
On 2016/05/13 21:56:10, Nate Chapin wrote: > Should there be a BUG= in the description? ...
4 years, 7 months ago (2016-05-13 23:30:43 UTC) #8
lfg
I've added the bug I'm fixing (but maybe I should create a new bug for ...
4 years, 7 months ago (2016-05-14 01:23:28 UTC) #10
Nate Chapin
https://codereview.chromium.org/1969723004/diff/60001/third_party/WebKit/Source/core/loader/FrameLoader.cpp File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right): https://codereview.chromium.org/1969723004/diff/60001/third_party/WebKit/Source/core/loader/FrameLoader.cpp#newcode1091 third_party/WebKit/Source/core/loader/FrameLoader.cpp:1091: NavigationCounterForUnload counter; On 2016/05/14 01:23:28, lfg wrote: > On ...
4 years, 7 months ago (2016-05-16 21:00:31 UTC) #12
lfg
https://codereview.chromium.org/1969723004/diff/60001/third_party/WebKit/Source/core/loader/FrameLoader.cpp File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right): https://codereview.chromium.org/1969723004/diff/60001/third_party/WebKit/Source/core/loader/FrameLoader.cpp#newcode1091 third_party/WebKit/Source/core/loader/FrameLoader.cpp:1091: NavigationCounterForUnload counter; On 2016/05/16 21:00:31, Nate Chapin wrote: > ...
4 years, 7 months ago (2016-05-16 23:46:54 UTC) #13
lfg
https://codereview.chromium.org/1969723004/diff/60001/third_party/WebKit/Source/core/loader/FrameLoader.cpp File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right): https://codereview.chromium.org/1969723004/diff/60001/third_party/WebKit/Source/core/loader/FrameLoader.cpp#newcode1091 third_party/WebKit/Source/core/loader/FrameLoader.cpp:1091: NavigationCounterForUnload counter; On 2016/05/16 21:00:31, Nate Chapin wrote: > ...
4 years, 7 months ago (2016-05-16 23:46:54 UTC) #14
lfg
Ping. Nate, can you take a look?
4 years, 7 months ago (2016-05-19 21:32:10 UTC) #15
Nate Chapin
lgtm
4 years, 7 months ago (2016-05-19 21:35:25 UTC) #16
lfg
+asvitkine@ for histograms.xml
4 years, 7 months ago (2016-05-19 21:55:50 UTC) #19
Alexei Svitkine (slow)
lgtm
4 years, 7 months ago (2016-05-20 15:26:41 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969723004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969723004/160001
4 years, 7 months ago (2016-05-25 22:02:34 UTC) #23
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 7 months ago (2016-05-26 01:21:47 UTC) #25
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 01:24:19 UTC) #27
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/9e8d2940fd58f042dd06e60367de9b2bd478c3bd
Cr-Commit-Position: refs/heads/master@{#396077}

Powered by Google App Engine
This is Rietveld 408576698