Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Side by Side Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 1969723004: Add a counter and a deprecation message when navigating in an unload handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adding line number to test expectation Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/frame/Deprecation.h" 5 #include "core/frame/Deprecation.h"
6 6
7 #include "core/dom/Document.h" 7 #include "core/dom/Document.h"
8 #include "core/dom/ExecutionContext.h" 8 #include "core/dom/ExecutionContext.h"
9 #include "core/frame/FrameConsole.h" 9 #include "core/frame/FrameConsole.h"
10 #include "core/frame/FrameHost.h" 10 #include "core/frame/FrameHost.h"
(...skipping 372 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 383
384 case UseCounter::During_Microtask_SyncXHR: 384 case UseCounter::During_Microtask_SyncXHR:
385 return willBeRemoved("Invoking 'send()' on a sync XHR during microtask e xecution", 53, "5647113010544640"); 385 return willBeRemoved("Invoking 'send()' on a sync XHR during microtask e xecution", 53, "5647113010544640");
386 386
387 case UseCounter::MediaStreamOnEnded: 387 case UseCounter::MediaStreamOnEnded:
388 return replacedWillBeRemoved("The MediaStream 'ended' event", "the Media Stream 'inactive' event", 53, "5730404371791872"); 388 return replacedWillBeRemoved("The MediaStream 'ended' event", "the Media Stream 'inactive' event", 53, "5730404371791872");
389 389
390 case UseCounter::UntrustedEventDefaultHandled: 390 case UseCounter::UntrustedEventDefaultHandled:
391 return String::format("A DOM event generated from JavaScript has trigger ed a default action inside the browser. This behavior is non-standard and will b e removed in %s. See https://www.chromestatus.com/features/5718803933560832 for more details.", milestoneString(53)); 391 return String::format("A DOM event generated from JavaScript has trigger ed a default action inside the browser. This behavior is non-standard and will b e removed in %s. See https://www.chromestatus.com/features/5718803933560832 for more details.", milestoneString(53));
392 392
393 case UseCounter::UnloadHandler_Navigation:
394 return "Navigating in the unload handler is deprecated and will be remov ed.";
395
393 // Features that aren't deprecated don't have a deprecation message. 396 // Features that aren't deprecated don't have a deprecation message.
394 default: 397 default:
395 return String(); 398 return String();
396 } 399 }
397 } 400 }
398 401
399 } // namespace blink 402 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698