Issue 1969683002: Update _charCodeApply, makeFixedStringUnmodifiable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1969683002: Update _charCodeApply, makeFixedStringUnmodifiable (Closed)

Created:
4 years, 7 months ago by sra1

Modified:
4 years, 7 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Update _charCodeApply, makeFixedStringUnmodifiable TBR=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/dab54cad2d78d6a8bd5aacab860bf39f1d6afcc3

Patch Set 1 #

Total comments: 1

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -26 lines)			Patch
M	lib/runtime/dart_sdk.js	View	2 chunks	+9 lines, -11 lines	0 comments	Download
M	tool/input_sdk/patch/internal_patch.dart	View	1 chunk	+3 lines, -3 lines	1 comment	Download
M	tool/input_sdk/private/js_helper.dart	View	1 chunk	+9 lines, -11 lines	0 comments	Download
M	tool/sdk_expected_errors.txt	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sra1

Committed patchset #1 (id:1) manually as dab54cad2d78d6a8bd5aacab860bf39f1d6afcc3 (presubmit successful).

4 years, 7 months ago (2016-05-11 01:44:46 UTC) #2

sra1

4 years, 7 months ago (2016-05-11 01:44:52 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/1969683002/diff/1/tool/input_sdk/patch/intern...
File tool/input_sdk/patch/internal_patch.dart (right):

https://codereview.chromium.org/1969683002/diff/1/tool/input_sdk/patch/intern...
tool/input_sdk/patch/internal_patch.dart:28: List/*<E>*/
makeFixedListUnmodifiable/*<E>*/(List/*<E>*/ fixedLengthList) {
It turns out that patches in dart2js require exactly matching argument names.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages