tool/input_sdk/patch/internal_patch.dart - Issue 1969683002: Update _charCodeApply, makeFixedStringUnmodifiable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tool/input_sdk/patch/internal_patch.dart

Issue 1969683002: Update _charCodeApply, makeFixedStringUnmodifiable (Closed) Base URL: https://github.com/dart-lang/dev_compiler@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tool/input_sdk/patch/internal_patch.dart

diff --git a/tool/input_sdk/patch/internal_patch.dart b/tool/input_sdk/patch/internal_patch.dart

index fa158de8cc47343cccf9d37ea1a0e3d341ac343b..3684b5b3bdc0233fe39bb27958bcaa1a06efbe14 100644

--- a/tool/input_sdk/patch/internal_patch.dart

+++ b/tool/input_sdk/patch/internal_patch.dart

@@ -25,7 +25,7 @@ List/*<E>*/ makeListFixedLength/*<E>*/(List/*<E>*/ growableList) {

}

@patch

-List/*<E>*/ makeFixedListUnmodifiable/*<E>*/(List/*<E>*/ list) {

- JSArray.markUnmodifiableList(list);

- return list;

+List/*<E>*/ makeFixedListUnmodifiable/*<E>*/(List/*<E>*/ fixedLengthList) {

sra1 2016/05/11 01:44:52 It turns out that patches in dart2js require exact

+ JSArray.markUnmodifiableList(fixedLengthList);

+ return fixedLengthList;

}

« no previous file with comments | « lib/runtime/dart_sdk.js ('k') | tool/input_sdk/private/js_helper.dart » ('j') | no next file with comments »