Disable HW H264 decoder for Win7 & add enable flag

Disable HW H264 decoder for Win7 & add enable flag

This CL disables HW H264 decoder which has problems on Win7.
Also, adds a new flag --enable-win7-webrtc-hw-h264-decoding to
enable it optionally.

BUG=webrtc:5717
Committed: https://crrev.com/07e4c503be95e6de9fda2e67c4031beaff58f806
Cr-Commit-Position: refs/heads/master@{#393323}

[emircan, 2016-05-11 01:35:37]

Description was changed from

==========
new flag

BUG=
==========

to

==========
Disable HW H264 for Windows 7 by default & add enable flag

BUG=webrtc:5717
==========

[emircan, 2016-05-11 01:38:24]

Description was changed from

==========
Disable HW H264 for Windows 7 by default & add enable flag

BUG=webrtc:5717
==========

to

==========
Disable HW H264 decoder for Win7 & add enable flag

This CL disables HW H264 decoder which has problems on Win7.
Also, adds a new flag enable-win7-hw-h264-decoding to enable
it optionally.

BUG=webrtc:5717
==========

[emircan, 2016-05-11 01:45:18]

emircan@chromium.org changed reviewers:
+ ananta@chromium.org, pbos@chromium.org, sievers@chromium.org

[emircan, 2016-05-11 01:50:58]

Patchset #1 (id:1) has been deleted

[emircan, 2016-05-11 01:51:10]

PTAL.

[emircan, 2016-05-11 18:29:30]

Patchset #2 (id:40001) has been deleted

[emircan, 2016-05-11 18:31:21]

Ping. I submitted a new patch to resolve the unittest issues.

[pbos, 2016-05-11 21:31:46]

Are we sure that this is not happening on Win8 or pre-Win7?

https://codereview.chromium.org/1969673002/diff/60001/content/public/common/c...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/1969673002/diff/60001/content/public/common/c...
content/public/common/content_switches.cc:1014: const char
kEnableWin7HWH264Decoding[] = "enable-win7-hw-h264-decoding";
Should this not name something webrtc? If so put that in both the switch string
and variable name.

[emircan, 2016-05-11 23:48:35]

Description was changed from

==========
Disable HW H264 decoder for Win7 & add enable flag

This CL disables HW H264 decoder which has problems on Win7.
Also, adds a new flag enable-win7-hw-h264-decoding to enable
it optionally.

BUG=webrtc:5717
==========

to

==========
Disable HW H264 decoder for Win7 & add enable flag

This CL disables HW H264 decoder which has problems on Win7.
Also, adds a new flag --enable-win7-webrtc-hw-h264-decoding to enable
it optionally.

BUG=webrtc:5717
==========

[emircan, 2016-05-11 23:48:56]

Description was changed from

==========
Disable HW H264 decoder for Win7 & add enable flag

This CL disables HW H264 decoder which has problems on Win7.
Also, adds a new flag --enable-win7-webrtc-hw-h264-decoding to enable
it optionally.

BUG=webrtc:5717
==========

to

==========
Disable HW H264 decoder for Win7 & add enable flag

This CL disables HW H264 decoder which has problems on Win7.
Also, adds a new flag --enable-win7-webrtc-hw-h264-decoding to 
enable it optionally.

BUG=webrtc:5717
==========

[emircan, 2016-05-11 23:50:14]

As far as I learned from Ananta, HW support is disabled on Win8. And we haven't
been able to reproduce it on any Win8.1 or 10 devices.

https://codereview.chromium.org/1969673002/diff/60001/content/public/common/c...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/1969673002/diff/60001/content/public/common/c...
content/public/common/content_switches.cc:1014: const char
kEnableWin7HWH264Decoding[] = "enable-win7-hw-h264-decoding";
On 2016/05/11 21:31:46, pbos wrote:
> Should this not name something webrtc? If so put that in both the switch
string
> and variable name.

Done.

[ananta, 2016-05-12 00:09:44]

On 2016/05/11 23:50:14, emircan wrote:
> As far as I learned from Ananta, HW support is disabled on Win8. And we
haven't
> been able to reproduce it on any Win8.1 or 10 devices.
> 
>
https://codereview.chromium.org/1969673002/diff/60001/content/public/common/c...
> File content/public/common/content_switches.cc (right):
> 
>
https://codereview.chromium.org/1969673002/diff/60001/content/public/common/c...
> content/public/common/content_switches.cc:1014: const char
> kEnableWin7HWH264Decoding[] = "enable-win7-hw-h264-decoding";
> On 2016/05/11 21:31:46, pbos wrote:
> > Should this not name something webrtc? If so put that in both the switch
> string
> > and variable name.
> 
> Done.

So H/W support is not disabled on Windows 8. It is just that Microsoft does not
support Windows 8 anymore. Windows 8.1 through 10 is what we care about now.
In any case we were not able to reproduce this on 8.1

Thanks
Ananta

[pbos-webrtc, 2016-05-12 00:16:11]

pbos@webrtc.org changed reviewers:
+ pbos@webrtc.org

[pbos-webrtc, 2016-05-12 00:16:12]

Does this break non-RTC_USE_H264 builds (e.g. Chromium) because we claim to
support H264 and announce it on Win7 but then don't create a H264 encoder for
it? From what I can read this fails at the point of creating the encoder, not
when creating supported profiles.

[pbos-webrtc, 2016-05-12 00:20:13]

lgtm with offline explanation (we never claim to support it without SW support
because we don't support H.264 HW encoding).

[pbos, 2016-05-12 01:00:18]

lgtm from other account

[emircan, 2016-05-12 18:58:23]

emircan@chromium.org changed reviewers:
- sievers@chromium.org

[emircan, 2016-05-12 18:59:28]

emircan@chromium.org changed reviewers:
+ avi@chromium.org, sievers@chromium.org

[Avi (use Gerrit), 2016-05-12 19:00:54]

lgtm

stampity stamp

[emircan, 2016-05-12 19:03:45]

The CQ bit was checked by emircan@chromium.org

[commit-bot: I haz the power, 2016-05-12 19:04:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1969673002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1969673002/80001

[commit-bot: I haz the power, 2016-05-12 19:11:24]

Description was changed from

==========
Disable HW H264 decoder for Win7 & add enable flag

This CL disables HW H264 decoder which has problems on Win7.
Also, adds a new flag --enable-win7-webrtc-hw-h264-decoding to 
enable it optionally.

BUG=webrtc:5717
==========

to

==========
Disable HW H264 decoder for Win7 & add enable flag

This CL disables HW H264 decoder which has problems on Win7.
Also, adds a new flag --enable-win7-webrtc-hw-h264-decoding to 
enable it optionally.

BUG=webrtc:5717
==========

[commit-bot: I haz the power, 2016-05-12 19:11:26]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-05-12 19:12:31]

Description was changed from

==========
Disable HW H264 decoder for Win7 & add enable flag

This CL disables HW H264 decoder which has problems on Win7.
Also, adds a new flag --enable-win7-webrtc-hw-h264-decoding to 
enable it optionally.

BUG=webrtc:5717
==========

to

==========
Disable HW H264 decoder for Win7 & add enable flag

This CL disables HW H264 decoder which has problems on Win7.
Also, adds a new flag --enable-win7-webrtc-hw-h264-decoding to
enable it optionally.

BUG=webrtc:5717

Committed: https://crrev.com/07e4c503be95e6de9fda2e67c4031beaff58f806
Cr-Commit-Position: refs/heads/master@{#393323}
==========

[commit-bot: I haz the power, 2016-05-12 19:12:32]

Patchset 3 (id:??) landed as
https://crrev.com/07e4c503be95e6de9fda2e67c4031beaff58f806
Cr-Commit-Position: refs/heads/master@{#393323}