Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1969543002: Unified usage of vector<unique_ptr<T>> (Closed)

Created:
4 years, 7 months ago by etiennep
Modified:
4 years, 7 months ago
Reviewers:
huangs
CC:
chromium-reviews, wfh+watch_chromium.org, huangs+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unified usage of vector<unique_ptr<T>> Replace occurrences of vector of ptr and ScopedVector (deprecated) by vector<unique_ptr<T>> BUG=554289 Committed: https://crrev.com/7d4e8eebaa558b2bdf045a11fd9bcc311be5e36d Cr-Commit-Position: refs/heads/master@{#393040}

Patch Set 1 #

Total comments: 22

Patch Set 2 : rebase-update #

Patch Set 3 : Apply style corrections #

Patch Set 4 : Add #include <utility> for std::move #

Patch Set 5 : Format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -45 lines) Patch
M courgette/disassembler_elf_32.h View 1 2 3 4 7 chunks +15 lines, -12 lines 0 comments Download
M courgette/disassembler_elf_32.cc View 1 2 4 chunks +9 lines, -6 lines 0 comments Download
M courgette/disassembler_elf_32_arm.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M courgette/disassembler_elf_32_x86.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M courgette/disassembler_elf_32_x86_unittest.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M courgette/ensemble_apply.cc View 1 2 3 4 5 chunks +13 lines, -23 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
etiennep
PTAL
4 years, 7 months ago (2016-05-10 19:56:35 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969543002/1
4 years, 7 months ago (2016-05-10 19:59:24 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/210085) linux_chromium_clobber_rel_ng on ...
4 years, 7 months ago (2016-05-10 20:25:22 UTC) #9
huangs
Looks good! There's a compiler error. You can find the cause bu clicking on the ...
4 years, 7 months ago (2016-05-11 04:49:24 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969543002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969543002/60001
4 years, 7 months ago (2016-05-11 18:18:44 UTC) #12
etiennep
PTAnL https://codereview.chromium.org/1969543002/diff/1/courgette/disassembler_elf_32.cc File courgette/disassembler_elf_32.cc (right): https://codereview.chromium.org/1969543002/diff/1/courgette/disassembler_elf_32.cc#newcode308 courgette/disassembler_elf_32.cc:308: auto current_rel = rel32_locations_.begin(); On 2016/05/11 04:49:23, huangs ...
4 years, 7 months ago (2016-05-11 18:19:16 UTC) #13
Avi (use Gerrit)
drive by This is bug 554289 ; please tag it as such.
4 years, 7 months ago (2016-05-11 18:32:33 UTC) #14
etiennep
On 2016/05/11 18:32:33, Avi wrote: > drive by > > This is bug 554289 ; ...
4 years, 7 months ago (2016-05-11 18:47:21 UTC) #16
huangs
Thanks! LGTM.
4 years, 7 months ago (2016-05-11 18:51:21 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969543002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969543002/80001
4 years, 7 months ago (2016-05-11 18:53:01 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-11 20:14:59 UTC) #21
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 20:16:39 UTC) #23
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7d4e8eebaa558b2bdf045a11fd9bcc311be5e36d
Cr-Commit-Position: refs/heads/master@{#393040}

Powered by Google App Engine
This is Rietveld 408576698