Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: courgette/disassembler_elf_32_x86_unittest.cc

Issue 1969543002: Unified usage of vector<unique_ptr<T>> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Format Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « courgette/disassembler_elf_32_x86.cc ('k') | courgette/ensemble_apply.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/disassembler_elf_32_x86_unittest.cc
diff --git a/courgette/disassembler_elf_32_x86_unittest.cc b/courgette/disassembler_elf_32_x86_unittest.cc
index 7060dd342efe0cdd6a31841fc3d80c248f702da8..af8a540f5ee737ff44188b4495325f1c63c84c75 100644
--- a/courgette/disassembler_elf_32_x86_unittest.cc
+++ b/courgette/disassembler_elf_32_x86_unittest.cc
@@ -67,7 +67,6 @@ class DisassemblerElf32X86Test : public BaseTest {
void DisassemblerElf32X86Test::TestExe(const char* file_name,
size_t expected_abs_count,
size_t expected_rel_count) const {
- using TypedRVA = DisassemblerElf32::TypedRVA;
std::string file1 = FileContents(file_name);
std::unique_ptr<TestDisassemblerElf32X86> disassembler(
@@ -98,7 +97,7 @@ void DisassemblerElf32X86Test::TestExe(const char* file_name,
// Flatten the list typed rel32 to a list of rel32 RVAs.
std::vector<RVA> rel32_list;
rel32_list.reserve(disassembler->Rel32Locations().size());
- for (TypedRVA* typed_rel32 : disassembler->Rel32Locations())
+ for (auto& typed_rel32 : disassembler->Rel32Locations())
rel32_list.push_back(typed_rel32->rva());
EXPECT_EQ(expected_abs_count, abs32_list.size());
« no previous file with comments | « courgette/disassembler_elf_32_x86.cc ('k') | courgette/ensemble_apply.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698