Parser / PreParser unification: Add docs.

Parser / PreParser unification: Add docs.

R=rossberg@chromium.org, rossberg
BUG=v8:3126
LOG=N

Committed: https://code.google.com/p/v8/source/detail?r=19861

[marja, 2014-03-12 16:23:48]

rossberg, ptal

[rossberg, 2014-03-12 16:36:03]

Do you think it would be possible to specify the trait a bit more concretely,
e.g. in the concepts-like style I used in types.h for TypeImpl?

[marja, 2014-03-12 16:41:59]

On 2014/03/12 16:36:03, rossberg wrote:
> Do you think it would be possible to specify the trait a bit more concretely,
> e.g. in the concepts-like style I used in types.h for TypeImpl?

Hmm, do you mean adding the comment about what typedefs and funcs the traits
must have? Or something else?

[rossberg, 2014-03-12 17:29:11]

Thanks. LGTM.

https://codereview.chromium.org/196953004/diff/20001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/196953004/diff/20001/src/preparser.h#newcode59
src/preparser.h:59: // The traits are expected to contain the following
typedefs:
Nit: For clarity, perhaps say "In particular, ..." here

https://codereview.chromium.org/196953004/diff/20001/src/preparser.h#newcode77
src/preparser.h:77: // };
...and "// ..." here.

[marja, 2014-03-12 19:07:45]

thx for review!

https://codereview.chromium.org/196953004/diff/20001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/196953004/diff/20001/src/preparser.h#newcode59
src/preparser.h:59: // The traits are expected to contain the following
typedefs:
On 2014/03/12 17:29:11, rossberg wrote:
> Nit: For clarity, perhaps say "In particular, ..." here

Done.

https://codereview.chromium.org/196953004/diff/20001/src/preparser.h#newcode77
src/preparser.h:77: // };
On 2014/03/12 17:29:11, rossberg wrote:
> ...and "// ..." here.

Done.

[marja, 2014-03-12 19:15:24]

Committed patchset #3 manually as r19861 (presubmit successful).