Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: src/parser.h

Issue 196953004: Parser / PreParser unification: Add docs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: moar Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/preparser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parser.h
diff --git a/src/parser.h b/src/parser.h
index 4bdf65957d57b6d70dfd63aabf4912154905baca..073d64b820c6e754b0e566338c2023faf81605a3 100644
--- a/src/parser.h
+++ b/src/parser.h
@@ -408,11 +408,12 @@ class SingletonLogger;
class ParserTraits {
public:
struct Type {
+ // TODO(marja): To be removed. The Traits object should contain all the data
+ // it needs.
typedef v8::internal::Parser* Parser;
- // Types used by FunctionState and BlockState.
+ // Used by FunctionState and BlockState.
typedef v8::internal::Scope Scope;
- typedef AstNodeFactory<AstConstructionVisitor> Factory;
typedef Variable GeneratorVariable;
typedef v8::internal::Zone Zone;
@@ -424,6 +425,9 @@ class ParserTraits {
typedef ObjectLiteral::Property* ObjectLiteralProperty;
typedef ZoneList<v8::internal::Expression*>* ExpressionList;
typedef ZoneList<ObjectLiteral::Property*>* PropertyList;
+
+ // For constructing objects returned by the traversing functions.
+ typedef AstNodeFactory<AstConstructionVisitor> Factory;
};
explicit ParserTraits(Parser* parser) : parser_(parser) {}
« no previous file with comments | « no previous file | src/preparser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698