Address more TOOD(GYP) in GN build.

Address more TOOD(GYP) in GN build.

Committed: https://crrev.com/d349ea40e2fb0ec66b7ee1cec23ca6e549593f68
Cr-Commit-Position: refs/heads/master@{#393334}

[brettw, 2016-05-10 19:19:38]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2016-05-10 19:19:39]

.

[commit-bot: I haz the power, 2016-05-10 19:20:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1969503002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1969503002/20001

[commit-bot: I haz the power, 2016-05-10 19:25:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-10 19:25:22]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[brettw, 2016-05-10 19:38:22]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2016-05-10 19:38:23]

android

[commit-bot: I haz the power, 2016-05-10 19:39:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1969503002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1969503002/40001

[brettw, 2016-05-10 19:51:32]

brettw@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brettw, 2016-05-10 19:51:33]

https://codereview.chromium.org/1969503002/diff/40001/extensions/BUILD.gn
File extensions/BUILD.gn (left):

https://codereview.chromium.org/1969503002/diff/40001/extensions/BUILD.gn#old...
extensions/BUILD.gn:257: # "$root_out_dir/wow_helper.exe"  # TODO(GYP)
This comes automatically because this target depends indirectly on the sandbox
via content.

https://codereview.chromium.org/1969503002/diff/40001/media/media_options.gni
File media/media_options.gni (left):

https://codereview.chromium.org/1969503002/diff/40001/media/media_options.gni...
media/media_options.gni:47: is_openbsd = false
This is unused.

https://codereview.chromium.org/1969503002/diff/40001/net/BUILD.gn
File net/BUILD.gn (left):

https://codereview.chromium.org/1969503002/diff/40001/net/BUILD.gn#oldcode75
net/BUILD.gn:75: # TODO(GYP) Note that the GYP file supports linux_link_kerberos
(defaults to
I suspect we never need the capability described in the comment since it's never
tested and nobody has complained.

https://codereview.chromium.org/1969503002/diff/40001/remoting/remoting_all.gyp
File remoting/remoting_all.gyp (left):

https://codereview.chromium.org/1969503002/diff/40001/remoting/remoting_all.g...
remoting/remoting_all.gyp:75: # TODO(GYP) Depends on crbug.com/471924 being
fixed for PNaCl.
I don't even know what this means. It's not a GN-transition thing, and the code
below seems to be enabled.

https://codereview.chromium.org/1969503002/diff/40001/sandbox/BUILD.gn
File sandbox/BUILD.gn (left):

https://codereview.chromium.org/1969503002/diff/40001/sandbox/BUILD.gn#oldcode13
sandbox/BUILD.gn:13: if (false) {
I believe 10.6 support is gone. In any case, this compiles.

[commit-bot: I haz the power, 2016-05-10 23:09:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-10 23:09:50]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-05-12 17:22:18]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2016-05-12 17:22:33]

ping

[commit-bot: I haz the power, 2016-05-12 17:22:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1969503002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1969503002/60001

[brucedawson, 2016-05-12 17:50:39]

lgtm

[commit-bot: I haz the power, 2016-05-12 18:35:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 18:35:18]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-05-12 19:41:53]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-05-12 19:42:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1969503002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1969503002/60001

[commit-bot: I haz the power, 2016-05-12 19:46:09]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-12 19:47:46]

Description was changed from

==========
Address more TOOD(GYP) in GN build.
==========

to

==========
Address more TOOD(GYP) in GN build.

Committed: https://crrev.com/d349ea40e2fb0ec66b7ee1cec23ca6e549593f68
Cr-Commit-Position: refs/heads/master@{#393334}
==========

[commit-bot: I haz the power, 2016-05-12 19:47:47]

Patchset 4 (id:??) landed as
https://crrev.com/d349ea40e2fb0ec66b7ee1cec23ca6e549593f68
Cr-Commit-Position: refs/heads/master@{#393334}