Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: skia/BUILD.gn

Issue 1969503002: Address more TOOD(GYP) in GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/linux/BUILD.gn ('k') | storage/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/BUILD.gn
diff --git a/skia/BUILD.gn b/skia/BUILD.gn
index 60e6f828bc414940da9bf32b62958745e90b9996..a2fd88aa2e047b50476d3c1509d35e8652714696 100644
--- a/skia/BUILD.gn
+++ b/skia/BUILD.gn
@@ -707,31 +707,28 @@ test("skia_unittests") {
}
}
-if (is_linux && !is_chromeos) {
- # TODO(GYP): Figure out which of these work and are needed on other platforms.
- executable("image_operations_bench") {
- sources = [
- "ext/image_operations_bench.cc",
- ]
+executable("image_operations_bench") {
+ sources = [
+ "ext/image_operations_bench.cc",
+ ]
- deps = [
- ":skia",
- "//base",
- "//build/config/sanitizers:deps",
- ]
- }
+ deps = [
+ ":skia",
+ "//base",
+ "//build/config/sanitizers:deps",
+ ]
+}
- executable("filter_fuzz_stub") {
- testonly = true
- sources = [
- "tools/filter_fuzz_stub/filter_fuzz_stub.cc",
- ]
+executable("filter_fuzz_stub") {
+ testonly = true
+ sources = [
+ "tools/filter_fuzz_stub/filter_fuzz_stub.cc",
+ ]
- deps = [
- ":skia",
- "//base",
- "//base/test:test_support",
- "//build/config/sanitizers:deps",
- ]
- }
+ deps = [
+ ":skia",
+ "//base",
+ "//base/test:test_support",
+ "//build/config/sanitizers:deps",
+ ]
}
« no previous file with comments | « sandbox/linux/BUILD.gn ('k') | storage/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698