Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: compute_engine_scripts/telemetry/telemetry_slave_scripts/vm_run_telemetry.sh

Issue 196943015: Automatically detect and remove invalid SKPs (using skpinfo) (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: Remove unused import Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « compute_engine_scripts/telemetry/telemetry_slave_scripts/remove_invalid_skps.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compute_engine_scripts/telemetry/telemetry_slave_scripts/vm_run_telemetry.sh
diff --git a/compute_engine_scripts/telemetry/telemetry_slave_scripts/vm_run_telemetry.sh b/compute_engine_scripts/telemetry/telemetry_slave_scripts/vm_run_telemetry.sh
index 41cd7b99c290ea9d959f22d017e5cfd7acc3048a..935ab01e2f77cefba790158792b79df0b013f185 100644
--- a/compute_engine_scripts/telemetry/telemetry_slave_scripts/vm_run_telemetry.sh
+++ b/compute_engine_scripts/telemetry/telemetry_slave_scripts/vm_run_telemetry.sh
@@ -147,6 +147,16 @@ if [ "$TELEMETRY_BENCHMARK" == "skpicture_printer" ]; then
find . -type f -size -10k
find . -type f -size -10k -exec rm {} \;
+ # Remove invalid SKPs found using the skpinfo binary.
+ # Sync trunk and build tools.
+ cd /home/default/skia-repo/trunk
+ for i in {1..3}; do /home/default/depot_tools/gclient sync && break || sleep 2; done
borenet 2014/03/14 16:22:58 Why do we need to retry this? Is there a need to
rmistry 2014/03/14 16:29:39 Discussed this in person: Retrying this because of
+ make clean
+ GYP_DEFINES="skia_warnings_as_errors=0" make tools BUILDTYPE=Release
+ echo "=====Calling remove_invalid_skps.py====="
+ cd /home/default/skia-repo/buildbot/compute_engine_scripts/telemetry/telemetry_slave_scripts
+ python remove_invalid_skps.py --skp_dir=/home/default/storage/skps/$PAGESETS_TYPE/$CHROMIUM_BUILD_DIR/ --path_to_skpinfo=/home/default/skia-repo/trunk/out/Release/skpinfo
+
# Now copy the SKP files to Google Storage.
gsutil cp /home/default/storage/skps/$PAGESETS_TYPE/$CHROMIUM_BUILD_DIR/* \
gs://chromium-skia-gm/telemetry/skps/slave$SLAVE_NUM/$PAGESETS_TYPE/$CHROMIUM_BUILD_DIR/
« no previous file with comments | « compute_engine_scripts/telemetry/telemetry_slave_scripts/remove_invalid_skps.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698