Automatically detect and remove invalid SKPs (using skpinfo)

compute_engine_scripts/telemetry/telemetry_slave_scripts/vm_run_telemetry.sh

 #!/bin/bash
 #
 # Runs all steps in vm_setup_slave.sh, calls run_multipage_benchmarks and copies
 # the output (if any) to Google Storage.
 #
 # The script should be run from the skia-telemetry-slave GCE instance's
 # /home/default/skia-repo/buildbot/compute_engine_scripts/telemetry/telemetry_slave_scripts
 # directory.
 #
 # Copyright 2013 Google Inc. All Rights Reserved.
@@ skipping 129 matching lines @@
     mv $LARGEST_SKP /home/default/storage/skps/$PAGESETS_TYPE/$CHROMIUM_BUILD_DIR/$SKP.skp
   done
 
   # Leave only SKP files in the skps directory.
   rm -rf /home/default/storage/skps/$PAGESETS_TYPE/$CHROMIUM_BUILD_DIR/*/
 
   # Delete all SKP files less than 10K (they will be the ones with errors).
   find . -type f -size -10k
   find . -type f -size -10k -exec rm {} \;
 
+  # Remove invalid SKPs found using the skpinfo binary.
+  # Sync trunk and build tools.
+  cd /home/default/skia-repo/trunk
+  for i in {1..3}; do /home/default/depot_tools/gclient sync && break || sleep 2; done

[borenet, 2014/03/14 16:22:58]

Why do we need to retry this?  Is there a need to run with --force?

[rmistry, 2014/03/14 16:29:39]

Discussed this in person: Retrying this because of some issues with gclient sync
I have seen in the past on these GCE instances (could be flaky network related).

+  make clean
+  GYP_DEFINES="skia_warnings_as_errors=0" make tools BUILDTYPE=Release
+  echo "=====Calling remove_invalid_skps.py====="
+  cd /home/default/skia-repo/buildbot/compute_engine_scripts/telemetry/telemetry_slave_scripts
+  python remove_invalid_skps.py --skp_dir=/home/default/storage/skps/$PAGESETS_TYPE/$CHROMIUM_BUILD_DIR/ --path_to_skpinfo=/home/default/skia-repo/trunk/out/Release/skpinfo
+
   # Now copy the SKP files to Google Storage. 
   gsutil cp /home/default/storage/skps/$PAGESETS_TYPE/$CHROMIUM_BUILD_DIR/* \
     gs://chromium-skia-gm/telemetry/skps/slave$SLAVE_NUM/$PAGESETS_TYPE/$CHROMIUM_BUILD_DIR/
   # Set ACLs for only google.com accounts to read the SKPs.
   gsutil acl ch -g google.com:READ gs://chromium-skia-gm/telemetry/skps/slave$SLAVE_NUM/$PAGESETS_TYPE/$CHROMIUM_BUILD_DIR/*
 
   # Create a TIMESTAMP file and copy it to Google Storage.
   TIMESTAMP=`date +%s`
   echo $TIMESTAMP > /tmp/$TIMESTAMP
   cp /tmp/$TIMESTAMP /home/default/storage/skps/$PAGESETS_TYPE/$CHROMIUM_BUILD_DIR/TIMESTAMP
   gsutil cp /tmp/$TIMESTAMP gs://chromium-skia-gm/telemetry/skps/slave$SLAVE_NUM/$PAGESETS_TYPE/$CHROMIUM_BUILD_DIR/TIMESTAMP
   rm /tmp/$TIMESTAMP
 fi
 
 # Clean up logs and the worker file.
 rm -rf ${OUTPUT_DIR}*
 delete_worker_file TELEMETRY_${RUN_ID}