Automatically detect and remove invalid SKPs (using skpinfo)

Automatically detect and remove invalid SKPs (using skpinfo)

BUG=skia:1057
R=borenet@google.com

Committed: https://skia.googlesource.com/buildbot/+/1dcf665

[robertphillips, 2014-03-14 15:33:33]

Watch out - skpinfo in action!

[borenet, 2014-03-14 16:22:58]

https://codereview.chromium.org/196943015/diff/20001/compute_engine_scripts/t...
File
compute_engine_scripts/telemetry/telemetry_slave_scripts/vm_run_telemetry.sh
(right):

https://codereview.chromium.org/196943015/diff/20001/compute_engine_scripts/t...
compute_engine_scripts/telemetry/telemetry_slave_scripts/vm_run_telemetry.sh:153:
for i in {1..3}; do /home/default/depot_tools/gclient sync && break || sleep 2;
done
Why do we need to retry this?  Is there a need to run with --force?

[borenet, 2014-03-14 16:27:51]

LGTM

[rmistry, 2014-03-14 16:29:34]

https://codereview.chromium.org/196943015/diff/20001/compute_engine_scripts/t...
File
compute_engine_scripts/telemetry/telemetry_slave_scripts/vm_run_telemetry.sh
(right):

https://codereview.chromium.org/196943015/diff/20001/compute_engine_scripts/t...
compute_engine_scripts/telemetry/telemetry_slave_scripts/vm_run_telemetry.sh:153:
for i in {1..3}; do /home/default/depot_tools/gclient sync && break || sleep 2;
done
On 2014/03/14 16:22:58, borenet wrote:
> Why do we need to retry this?  Is there a need to run with --force?

Discussed this in person: Retrying this because of some issues with gclient sync
I have seen in the past on these GCE instances (could be flaky network related).

[rmistry, 2014-03-14 16:29:44]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2014-03-14 16:29:55]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/rmistry@google.com/196943015/20001

[commit-bot: I haz the power, 2014-03-14 16:30:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-14 16:30:02]

Failed to apply the patch.

[rmistry, 2014-03-14 16:31:03]

On 2014/03/14 16:30:02, I haz the power (commit-bot) wrote:
> Failed to apply the patch.

huh?

[rmistry, 2014-03-14 16:31:22]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2014-03-14 16:31:26]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/rmistry@google.com/196943015/20001

[commit-bot: I haz the power, 2014-03-14 16:31:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-14 16:31:31]

Failed to apply the patch.

[rmistry, 2014-03-14 16:33:40]

On 2014/03/14 16:31:31, I haz the power (commit-bot) wrote:
> Failed to apply the patch.

Hi Aaron, the skiabuildbot CQ is failing immediately with 'Failed to apply the
patch.' without providing the failure.
Also, AFAIK the patch should not fail to apply, is this related to the new
GitCheckout changes? does the CQ need to be restarted or the workdir cleaned?

[rmistry, 2014-03-14 16:34:34]

Committed patchset #2 manually as r1dcf665 (presubmit successful).