Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 196943014: Split Promise API into Promise/Resolver (Closed)

Created:
6 years, 9 months ago by rossberg
Modified:
6 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Split Promise API into Promise/Resolver R=svenpanne@chromium.org BUG= LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=19972

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -34 lines) Patch
M include/v8.h View 2 chunks +32 lines, -10 lines 0 comments Download
M src/api.cc View 4 chunks +21 lines, -8 lines 0 comments Download
M test/cctest/test-api.cc View 5 chunks +18 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rossberg
6 years, 9 months ago (2014-03-14 10:31:16 UTC) #1
Sven Panne
lgtm
6 years, 9 months ago (2014-03-14 10:39:27 UTC) #2
yhirano
The current ScriptPromise / ScriptPromiseResolver API doesn't match with v8::Promise and v8::Promise::Resolver. I am checking ...
6 years, 9 months ago (2014-03-14 10:52:19 UTC) #3
yhirano
> I am checking whether I can change the API and modify all caller side ...
6 years, 9 months ago (2014-03-14 13:24:36 UTC) #4
rossberg
On 2014/03/14 13:24:36, yhirano wrote: > > I am checking whether I can change the ...
6 years, 9 months ago (2014-03-14 13:30:08 UTC) #5
rossberg
On 2014/03/14 13:30:08, rossberg wrote: > On 2014/03/14 13:24:36, yhirano wrote: > > > I ...
6 years, 9 months ago (2014-03-14 16:58:41 UTC) #6
rossberg
6 years, 9 months ago (2014-03-17 09:57:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r19972 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698