Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Unified Diff: test/cctest/test-api.cc

Issue 196943014: Split Promise API into Promise/Resolver (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index 01c9ca9b81b23ad7980d451fddf1ecb42b838fb6..17a26b341f33cc4c4bdc5a1b426a6944b8a4b1aa 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -22231,8 +22231,10 @@ TEST(Promises) {
Handle<Object> global = context->Global();
// Creation.
- Handle<v8::Promise> p = v8::Promise::New(isolate);
- Handle<v8::Promise> r = v8::Promise::New(isolate);
+ Handle<v8::Promise::Resolver> pr = v8::Promise::Resolver::New(isolate);
+ Handle<v8::Promise::Resolver> rr = v8::Promise::Resolver::New(isolate);
+ Handle<v8::Promise> p = pr->GetPromise();
+ Handle<v8::Promise> r = rr->GetPromise();
// IsPromise predicate.
CHECK(p->IsPromise());
@@ -22241,9 +22243,9 @@ TEST(Promises) {
CHECK(!o->IsPromise());
// Resolution and rejection.
- p->Resolve(v8::Integer::New(isolate, 1));
+ pr->Resolve(v8::Integer::New(isolate, 1));
CHECK(p->IsPromise());
- r->Reject(v8::Integer::New(isolate, 2));
+ rr->Reject(v8::Integer::New(isolate, 2));
CHECK(r->IsPromise());
// Chaining non-pending promises.
@@ -22275,17 +22277,17 @@ TEST(Promises) {
// Chaining pending promises.
CompileRun("x1 = x2 = 0;");
- p = v8::Promise::New(isolate);
- r = v8::Promise::New(isolate);
+ pr = v8::Promise::Resolver::New(isolate);
+ rr = v8::Promise::Resolver::New(isolate);
- p->Chain(f1);
- r->Catch(f2);
+ pr->GetPromise()->Chain(f1);
+ rr->GetPromise()->Catch(f2);
V8::RunMicrotasks(isolate);
CHECK_EQ(0, global->Get(v8_str("x1"))->Int32Value());
CHECK_EQ(0, global->Get(v8_str("x2"))->Int32Value());
- p->Resolve(v8::Integer::New(isolate, 1));
- r->Reject(v8::Integer::New(isolate, 2));
+ pr->Resolve(v8::Integer::New(isolate, 1));
+ rr->Reject(v8::Integer::New(isolate, 2));
CHECK_EQ(0, global->Get(v8_str("x1"))->Int32Value());
CHECK_EQ(0, global->Get(v8_str("x2"))->Int32Value());
@@ -22295,9 +22297,9 @@ TEST(Promises) {
// Multi-chaining.
CompileRun("x1 = x2 = 0;");
- p = v8::Promise::New(isolate);
- p->Chain(f1)->Chain(f2);
- p->Resolve(v8::Integer::New(isolate, 3));
+ pr = v8::Promise::Resolver::New(isolate);
+ pr->GetPromise()->Chain(f1)->Chain(f2);
+ pr->Resolve(v8::Integer::New(isolate, 3));
CHECK_EQ(0, global->Get(v8_str("x1"))->Int32Value());
CHECK_EQ(0, global->Get(v8_str("x2"))->Int32Value());
V8::RunMicrotasks(isolate);
@@ -22305,9 +22307,9 @@ TEST(Promises) {
CHECK_EQ(4, global->Get(v8_str("x2"))->Int32Value());
CompileRun("x1 = x2 = 0;");
- r = v8::Promise::New(isolate);
- r->Catch(f1)->Chain(f2);
- r->Reject(v8::Integer::New(isolate, 3));
+ rr = v8::Promise::Resolver::New(isolate);
+ rr->GetPromise()->Catch(f1)->Chain(f2);
+ rr->Reject(v8::Integer::New(isolate, 3));
CHECK_EQ(0, global->Get(v8_str("x1"))->Int32Value());
CHECK_EQ(0, global->Get(v8_str("x2"))->Int32Value());
V8::RunMicrotasks(isolate);
« no previous file with comments | « src/api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698