third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp - Issue 1969403004: Expose and check origin of request in response for foreign fetch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

Issue 1969403004: Expose and check origin of request in response for foreign fetch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@set-request-and-credentials-mode

Patch Set: update layouttests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp ('K') | « third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp ('k') | third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponseError.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

index 471de234d334dbe63c9126a5f2baeccb75d78617..9818eef3f1731f339584f409e8ddb644ae8379bb 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

@@ -147,12 +147,14 @@ void ServiceWorkerGlobalScopeProxy::dispatchFetchEvent(int eventID, const WebSer

void ServiceWorkerGlobalScopeProxy::dispatchForeignFetchEvent(int eventID, const WebServiceWorkerRequest& webRequest)

{

- ForeignFetchRespondWithObserver* observer = ForeignFetchRespondWithObserver::create(workerGlobalScope(), eventID, webRequest.url(), webRequest.mode(), webRequest.frameType(), webRequest.requestContext());

+ RefPtr<SecurityOrigin> origin = SecurityOrigin::create(webRequest.referrerUrl());

+ ForeignFetchRespondWithObserver* observer = ForeignFetchRespondWithObserver::create(workerGlobalScope(), eventID, webRequest.url(), webRequest.mode(), webRequest.frameType(), webRequest.requestContext(), origin);

Request* request = Request::create(workerGlobalScope()->scriptController()->getScriptState(), webRequest);

request->getHeaders()->setGuard(Headers::ImmutableGuard);

ForeignFetchEventInit eventInit;

eventInit.setCancelable(true);

eventInit.setRequest(request);

+ eventInit.setOrigin(origin->toString());

ForeignFetchEvent* fetchEvent = ForeignFetchEvent::create(EventTypeNames::foreignfetch, eventInit, observer);

DispatchEventResult dispatchResult = workerGlobalScope()->dispatchEvent(fetchEvent);

observer->didDispatchEvent(dispatchResult);