third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp - Issue 1969403004: Expose and check origin of request in response for foreign fetch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

Issue 1969403004: Expose and check origin of request in response for foreign fetch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@set-request-and-credentials-mode

Patch Set: update layouttests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp ('K') | « third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp ('k') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

index 28b433d6e34f4d09d9f947e0c22726d97a96dc77..5c0d70895f69dd01c532329342ff3e778281bed6 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

@@ -62,6 +62,12 @@ const String getMessageForResponseError(WebServiceWorkerResponseError error, con

case WebServiceWorkerResponseErrorNoForeignFetchResponse:

errorMessage = errorMessage + "an object that was not a ForeignFetchResponse was passed to respondWith().";

break;

+ case WebServiceWorkerResponseErrorForeignFetchHeadersWithoutOrigin:

+ errorMessage = errorMessage + "headers were specified for a response without an explicit origin.";

+ break;

+ case WebServiceWorkerResponseErrorForeignFetchMismatchedOrigin:

+ errorMessage = errorMessage + "origin in response does not match origin of request.";

+ break;

case WebServiceWorkerResponseErrorUnknown:

default:

errorMessage = errorMessage + "an unexpected error occurred.";