Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1969293002: Remove net::ParsedCertificate struct. (Closed)

Created:
4 years, 7 months ago by mattm
Modified:
4 years, 7 months ago
Reviewers:
eroman, sheretov
CC:
chromium-reviews, cbentzel+watch_chromium.org, sheretov+watch_chromium.org, dougsteed+watch_chromium.org, vadimgo+watch_chromium.org, ryanchung+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove net::ParsedCertificate struct. This is in preparation for further refactoring of verify_certificate_chain.cc BUG=410574 Committed: https://crrev.com/940d28f4fbe2085bef03f79d8eea96b9cd79ca0d Cr-Commit-Position: refs/heads/master@{#394244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -110 lines) Patch
M components/cast_certificate/cast_cert_validator.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M net/cert/internal/parse_certificate.h View 3 chunks +32 lines, -47 lines 0 comments Download
M net/cert/internal/parse_certificate.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M net/cert/internal/parse_certificate_fuzzer.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M net/cert/internal/parse_certificate_unittest.cc View 2 chunks +15 lines, -10 lines 0 comments Download
M net/cert/internal/parse_ocsp.h View 1 chunk +10 lines, -9 lines 0 comments Download
M net/cert/internal/parse_ocsp.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/cert/internal/parse_ocsp_unittest.cc View 2 chunks +13 lines, -5 lines 0 comments Download
M net/cert/internal/verify_certificate_chain.cc View 6 chunks +23 lines, -14 lines 0 comments Download
M net/cert/x509_util_openssl.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M net/net.gypi View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 1976433002 Patch 40001
Issue 1976433002 Patch 60001
Issue 1976433002 Patch 80001

Messages

Total messages: 11 (4 generated)
mattm
1st part split off of https://codereview.chromium.org/1923433002/
4 years, 7 months ago (2016-05-12 03:39:45 UTC) #2
eroman
lgtm
4 years, 7 months ago (2016-05-12 17:21:32 UTC) #3
mattm
+sheretov for OWNERS review of components/cast_certificate/cast_cert_validator.cc
4 years, 7 months ago (2016-05-17 19:38:22 UTC) #5
sheretov
LGTM for components/cast_certificate/cast_cert_validator.cc
4 years, 7 months ago (2016-05-17 20:08:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969293002/1
4 years, 7 months ago (2016-05-17 20:16:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 22:24:02 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 22:25:24 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/940d28f4fbe2085bef03f79d8eea96b9cd79ca0d
Cr-Commit-Position: refs/heads/master@{#394244}

Powered by Google App Engine
This is Rietveld 408576698