Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: net/cert/internal/parse_certificate.cc

Issue 1969293002: Remove net::ParsedCertificate struct. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/parse_certificate.h ('k') | net/cert/internal/parse_certificate_fuzzer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/parse_certificate.cc
diff --git a/net/cert/internal/parse_certificate.cc b/net/cert/internal/parse_certificate.cc
index 738d91b13d256d7f43ac03c0449a04264029ee01..6bf3e3ae623eb685024e621b4689af94fd97f1c5 100644
--- a/net/cert/internal/parse_certificate.cc
+++ b/net/cert/internal/parse_certificate.cc
@@ -150,10 +150,6 @@ WARN_UNUSED_RESULT bool BitStringIsAllZeros(const der::BitString& bits) {
} // namespace
-ParsedCertificate::ParsedCertificate() {}
-
-ParsedCertificate::~ParsedCertificate() {}
-
ParsedTbsCertificate::ParsedTbsCertificate() {}
ParsedTbsCertificate::~ParsedTbsCertificate() {}
@@ -171,7 +167,9 @@ bool VerifySerialNumber(const der::Input& value) {
}
bool ParseCertificate(const der::Input& certificate_tlv,
- ParsedCertificate* out) {
+ der::Input* out_tbs_certificate_tlv,
+ der::Input* out_signature_algorithm_tlv,
+ der::BitString* out_signature_value) {
der::Parser parser(certificate_tlv);
// Certificate ::= SEQUENCE {
@@ -180,15 +178,15 @@ bool ParseCertificate(const der::Input& certificate_tlv,
return false;
// tbsCertificate TBSCertificate,
- if (!ReadSequenceTLV(&certificate_parser, &out->tbs_certificate_tlv))
+ if (!ReadSequenceTLV(&certificate_parser, out_tbs_certificate_tlv))
return false;
// signatureAlgorithm AlgorithmIdentifier,
- if (!ReadSequenceTLV(&certificate_parser, &out->signature_algorithm_tlv))
+ if (!ReadSequenceTLV(&certificate_parser, out_signature_algorithm_tlv))
return false;
// signatureValue BIT STRING }
- if (!certificate_parser.ReadBitString(&out->signature_value))
+ if (!certificate_parser.ReadBitString(out_signature_value))
return false;
// There isn't an extension point at the end of Certificate.
« no previous file with comments | « net/cert/internal/parse_certificate.h ('k') | net/cert/internal/parse_certificate_fuzzer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698