Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Issue 1969253003: Reland of Clean up IPAddress::ToString related TODO. (Closed)

Created:
4 years, 7 months ago by tommycli
Modified:
4 years, 7 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Clean up IPAddress::ToString related TODO. (patchset #1 id:1 of https://codereview.chromium.org/1964143005/ ) Reason for revert: Reverting this patch did not fix the issue. Sorry. Original issue's description: > Revert of Clean up IPAddress::ToString related TODO. (patchset #1 id:1 of https://codereview.chromium.org/1957753002/ ) > > Reason for revert: > Speculatively reverting because this may have broken a Dr. Memory bot: > > First breaking build: > https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%281%29/builds/4845 > > Original issue's description: > > Clean up IPAddress::ToString related TODO. > > > > Committed: https://crrev.com/b8db9ba385ae3a2823a5dcc48acaf889c0f650f3 > > Cr-Commit-Position: refs/heads/master@{#392670} > > TBR=eroman@chromium.org,sergeyu@chromium.org,martijn@martijnc.be > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/3b09400275a762dddbf6c1a3b0603ee554957d46 > Cr-Commit-Position: refs/heads/master@{#392962} TBR=eroman@chromium.org,sergeyu@chromium.org,martijn@martijnc.be # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/3e561e57c97f5b6b8ce70fdc6a9092818eaa628d Cr-Commit-Position: refs/heads/master@{#393366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M net/quic/p2p/quic_p2p_session.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
tommycli
Created Reland of Clean up IPAddress::ToString related TODO.
4 years, 7 months ago (2016-05-12 20:43:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969253003/1
4 years, 7 months ago (2016-05-12 20:44:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969253003/1
4 years, 7 months ago (2016-05-12 21:01:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969253003/1
4 years, 7 months ago (2016-05-12 21:31:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 21:47:18 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 21:49:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e561e57c97f5b6b8ce70fdc6a9092818eaa628d
Cr-Commit-Position: refs/heads/master@{#393366}

Powered by Google App Engine
This is Rietveld 408576698