Reland of Clean up IPAddress::ToString related TODO.

net/quic/p2p/quic_p2p_session.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/p2p/quic_p2p_session.h"
 
 #include <utility>
 
 #include "base/callback_helpers.h"
 #include "net/base/io_buffer.h"
 #include "net/base/ip_address.h"
 #include "net/base/net_errors.h"
 #include "net/quic/p2p/quic_p2p_crypto_stream.h"
 #include "net/quic/p2p/quic_p2p_stream.h"
 #include "net/quic/quic_connection.h"
 #include "net/socket/socket.h"
 
 namespace net {
 
 QuicP2PSession::QuicP2PSession(const QuicConfig& config,
                                const QuicP2PCryptoConfig& crypto_config,
                                std::unique_ptr<QuicConnection> connection,
                                std::unique_ptr<Socket> socket)
     : QuicSession(connection.release(), config),
       socket_(std::move(socket)),
       crypto_stream_(new QuicP2PCryptoStream(this, crypto_config)),
       read_buffer_(new IOBuffer(static_cast<size_t>(kMaxPacketSize))) {
   DCHECK(config.negotiated());
-
-  // Non-null IP address needs to be passed here because QuicConnection uses
-  // ToString() to format addresses for logging and ToString() is not allowed
-  // for empty addresses.
-  // TODO(sergeyu): Fix QuicConnection and remove SetSelfAddress() call below.
-  this->connection()->SetSelfAddress(IPEndPoint(IPAddress::IPv4AllZeros(), 0));
 }
 
 QuicP2PSession::~QuicP2PSession() {}
 
 void QuicP2PSession::Initialize() {
   QuicSession::Initialize();
   crypto_stream_->Connect();
   DoReadLoop(OK);
 }
 
@@ skipping 80 matching lines @@
     return result;
   }
 
   QuicReceivedPacket packet(read_buffer_->data(), result, clock_.Now());
   connection()->ProcessUdpPacket(connection()->self_address(),
                                  connection()->peer_address(), packet);
   return OK;
 }
 
 }  // namespace net