Unreachable code fixes in SelectorChecker.

Unreachable code fixes in SelectorChecker.

Unknown selectors and pseudo page selectors should be dropped at parse
time for element selectors. Also did some simplifications for
ASSERT_NOT_REACHED code and consistently fail matching for such code.

R=timloh@chromium.org,rob.buis@samsung.com

Committed: https://crrev.com/987b25df2940ffc9f57b9938086c5163d87002ef
Cr-Commit-Position: refs/heads/master@{#393216}

[rune, 2016-05-11 23:11:24]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[rune, 2016-05-11 23:11:34]

ptal

[commit-bot: I haz the power, 2016-05-11 23:11:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1969203002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1969203002/1

[commit-bot: I haz the power, 2016-05-11 23:32:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 23:32:48]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[Timothy Loh, 2016-05-12 03:58:49]

bots are red?

[rune, 2016-05-12 08:37:03]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 08:37:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1969203002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1969203002/20001

[rune, 2016-05-12 08:37:48]

On 2016/05/12 03:58:49, Timothy Loh wrote:
> bots are red?

Some compilers wasn't able to figure out that all code paths led to a return.
Hopefully fixed now.

[Timothy Loh, 2016-05-12 08:38:35]

On 2016/05/12 08:37:48, rune wrote:
> On 2016/05/12 03:58:49, Timothy Loh wrote:
> > bots are red?
> 
> Some compilers wasn't able to figure out that all code paths led to a return.
> Hopefully fixed now.

lgtm

[rwlbuis, 2016-05-12 08:47:00]

Lgtm 2.

[commit-bot: I haz the power, 2016-05-12 09:42:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 09:42:16]

Dry run: This issue passed the CQ dry run.

[rune, 2016-05-12 09:50:27]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-05-12 09:50:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1969203002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1969203002/20001

[commit-bot: I haz the power, 2016-05-12 09:54:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-12 09:55:22]

Description was changed from

==========
Unreachable code fixes in SelectorChecker.

Unknown selectors and pseudo page selectors should be dropped at parse
time for element selectors. Also did some simplifications for
ASSERT_NOT_REACHED code and consistently fail matching for such code.

R=timloh@chromium.org,rob.buis@samsung.com
==========

to

==========
Unreachable code fixes in SelectorChecker.

Unknown selectors and pseudo page selectors should be dropped at parse
time for element selectors. Also did some simplifications for
ASSERT_NOT_REACHED code and consistently fail matching for such code.

R=timloh@chromium.org,rob.buis@samsung.com

Committed: https://crrev.com/987b25df2940ffc9f57b9938086c5163d87002ef
Cr-Commit-Position: refs/heads/master@{#393216}
==========

[commit-bot: I haz the power, 2016-05-12 09:55:23]

Patchset 2 (id:??) landed as
https://crrev.com/987b25df2940ffc9f57b9938086c5163d87002ef
Cr-Commit-Position: refs/heads/master@{#393216}