Unreachable code fixes in SelectorChecker.

third_party/WebKit/Source/core/css/SelectorChecker.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
  * Copyright (C) Research In Motion Limited 2011. All rights reserved.
@@ skipping 379 matching lines @@
         {
             const HTMLSlotElement* slot = findSlotElementInScope(context);
             if (!slot)
                 return SelectorFailsCompletely;
 
             nextContext.element = const_cast<HTMLSlotElement*>(slot);
             return matchSelector(nextContext, result);
         }
 
     case CSSSelector::SubSelector:
-        ASSERT_NOT_REACHED();
+        break;
     }
-
     ASSERT_NOT_REACHED();
     return SelectorFailsCompletely;
 }
 
 SelectorChecker::Match SelectorChecker::matchForPseudoContent(const SelectorCheckingContext& context, const Element& element, MatchResult& result) const
 {
     HeapVector<Member<InsertionPoint>, 8> insertionPoints;
     collectDestinationInsertionPoints(element, insertionPoints);
     SelectorCheckingContext nextContext(context);
     for (const auto& insertionPoint : insertionPoints) {
@@ skipping 75 matching lines @@
     case CSSSelector::AttributeHyphen:
         if (value.length() < selectorValue.length())
             return false;
         if (!value.startsWith(selectorValue, caseSensitivity))
             return false;
         // It they start the same, check for exact match or following '-':
         if (value.length() != selectorValue.length() && value[selectorValue.length()] != '-')
             return false;
         return true;
     default:
-        break;
+        ASSERT_NOT_REACHED();
+        return false;
     }
-
-    ASSERT_NOT_REACHED();
-    return true;
 }
 
 static bool anyAttributeMatches(Element& element, CSSSelector::MatchType match, const CSSSelector& selector)
 {
     const QualifiedName& selectorAttr = selector.attribute();
     ASSERT(selectorAttr.localName() != starAtom); // Should not be possible from the CSS grammar.
 
     // Synchronize the attribute in case it is lazy-computed.
     // Currently all lazy properties have a null namespace, so only pass localName().
     element.synchronizeAttribute(selectorAttr.localName());
@@ skipping 62 matching lines @@
     case CSSSelector::AttributeContain:
     case CSSSelector::AttributeBegin:
     case CSSSelector::AttributeEnd:
         return anyAttributeMatches(element, selector.match(), selector);
 
     case CSSSelector::PseudoClass:
         return checkPseudoClass(context, result);
     case CSSSelector::PseudoElement:
         return checkPseudoElement(context, result);
 
-    case CSSSelector::PagePseudoClass:
-        // FIXME: what?
-        return true;
-    case CSSSelector::Unknown:
-        // FIXME: what?
-        return true;
+    default:
+        ASSERT_NOT_REACHED();
+        return false;
     }
-    ASSERT_NOT_REACHED();
-    return true;
 }
 
 bool SelectorChecker::checkPseudoNot(const SelectorCheckingContext& context, MatchResult& result) const
 {
     const CSSSelector& selector = *context.selector;
 
     SelectorCheckingContext subContext(context);
     subContext.isSubSelector = true;
     ASSERT(selector.selectorList());
     for (subContext.selector = selector.selectorList()->first(); subContext.selector; subContext.selector = subContext.selector->tagHistory()) {
@@ skipping 531 matching lines @@
 }
 
 bool SelectorChecker::matchesFocusPseudoClass(const Element& element)
 {
     if (InspectorInstrumentation::forcePseudoState(const_cast<Element*>(&element), CSSSelector::PseudoFocus))
         return true;
     return element.focused() && isFrameFocused(element);
 }
 
 } // namespace blink