Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1968933002: Fix: tabs slow to response to beforeunload are closed prematurely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Correct order of checks Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/beforeunload_slow.html ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index 45d8ca0cffc75a6862df86dcbaef4b24a71fe007..bc020fb0e5133d0fd0d65d894f810a2aa2e679f5 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -401,6 +401,9 @@ class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost,
// PlzNavigate: this call happens on all browser-initiated navigations.
void DispatchBeforeUnload(bool for_navigation);
+ // Simulate beforeunload ack on behalf of renderer if it's unrenresponsive.
+ void SimulateBeforeUnloadAck();
+
// Returns true if a call to DispatchBeforeUnload will actually send the
// BeforeUnload IPC. This is the case if the current renderer is live and this
// frame is the main frame.
« no previous file with comments | « chrome/test/data/beforeunload_slow.html ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698