Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1968933002: Fix: tabs slow to response to beforeunload are closed prematurely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Correct order of checks Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 383 matching lines...) Expand 10 before | Expand all | Expand 10 after
394 // canceled or suspended. This is important if we later return to this 394 // canceled or suspended. This is important if we later return to this
395 // RenderFrameHost. 395 // RenderFrameHost.
396 void CancelSuspendedNavigations(); 396 void CancelSuspendedNavigations();
397 397
398 // Runs the beforeunload handler for this frame. |for_navigation| indicates 398 // Runs the beforeunload handler for this frame. |for_navigation| indicates
399 // whether this call is for the current frame during a cross-process 399 // whether this call is for the current frame during a cross-process
400 // navigation. False means we're closing the entire tab. 400 // navigation. False means we're closing the entire tab.
401 // PlzNavigate: this call happens on all browser-initiated navigations. 401 // PlzNavigate: this call happens on all browser-initiated navigations.
402 void DispatchBeforeUnload(bool for_navigation); 402 void DispatchBeforeUnload(bool for_navigation);
403 403
404 // Simulate beforeunload ack on behalf of renderer if it's unrenresponsive.
405 void SimulateBeforeUnloadAck();
406
404 // Returns true if a call to DispatchBeforeUnload will actually send the 407 // Returns true if a call to DispatchBeforeUnload will actually send the
405 // BeforeUnload IPC. This is the case if the current renderer is live and this 408 // BeforeUnload IPC. This is the case if the current renderer is live and this
406 // frame is the main frame. 409 // frame is the main frame.
407 bool ShouldDispatchBeforeUnload(); 410 bool ShouldDispatchBeforeUnload();
408 411
409 // Update the frame's opener in the renderer process in response to the 412 // Update the frame's opener in the renderer process in response to the
410 // opener being modified (e.g., with window.open or being set to null) in 413 // opener being modified (e.g., with window.open or being set to null) in
411 // another renderer process. 414 // another renderer process.
412 void UpdateOpener(); 415 void UpdateOpener();
413 416
(...skipping 559 matching lines...) Expand 10 before | Expand all | Expand 10 after
973 976
974 // NOTE: This must be the last member. 977 // NOTE: This must be the last member.
975 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_; 978 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
976 979
977 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 980 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
978 }; 981 };
979 982
980 } // namespace content 983 } // namespace content
981 984
982 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 985 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/test/data/beforeunload_slow.html ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698