Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 196893003: Introduce addp, idivp, imulp and subp for x64 port (Closed)

Created:
6 years, 9 months ago by haitao.feng
Modified:
6 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Introduce addp, idivp, imulp and subp for x64 port R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20140

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -354 lines) Patch
M src/x64/assembler-x64.h View 7 chunks +139 lines, -99 lines 2 comments Download
M src/x64/assembler-x64.cc View 2 chunks +12 lines, -60 lines 0 comments Download
M src/x64/builtins-x64.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 31 chunks +38 lines, -38 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/debug-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/deoptimizer-x64.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 12 chunks +13 lines, -13 lines 0 comments Download
M src/x64/ic-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 13 chunks +23 lines, -23 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 43 chunks +63 lines, -62 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 19 chunks +27 lines, -27 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-disasm-x64.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
haitao.feng
PTAL. Some addq/subq are kept when they are used to manipulate 64-bit value or calculate ...
6 years, 9 months ago (2014-03-19 15:14:02 UTC) #1
haitao.feng
https://codereview.chromium.org/196893003/diff/1/src/x64/assembler-x64.h File src/x64/assembler-x64.h (right): https://codereview.chromium.org/196893003/diff/1/src/x64/assembler-x64.h#newcode1658 src/x64/assembler-x64.h:1658: arithmetic_op_32(0x03, dst, src); The arithmetic_op and arithmetic_op_32 could be ...
6 years, 9 months ago (2014-03-19 15:21:25 UTC) #2
Toon Verwaest
lgtm https://codereview.chromium.org/196893003/diff/1/src/x64/assembler-x64.h File src/x64/assembler-x64.h (right): https://codereview.chromium.org/196893003/diff/1/src/x64/assembler-x64.h#newcode1658 src/x64/assembler-x64.h:1658: arithmetic_op_32(0x03, dst, src); Sounds good. On 2014/03/19 15:21:25, ...
6 years, 9 months ago (2014-03-20 10:43:50 UTC) #3
haitao.feng
6 years, 9 months ago (2014-03-21 02:42:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r20140 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698