Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19688011: Code generator makes useless include line to the binding files. (Closed)

Created:
7 years, 5 months ago by kihong
Modified:
7 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Code generator makes useless include line to the binding files. There are useless include statement in the Internals.idl, because of generating duplicated include statements from code generator. It is better to remove it from code generator. BUG=263278 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154890

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/bindings/scripts/deprecated_code_generator_v8.pm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
haraken
LGTM. Actually we have a bunch of unnecessary AddToImplIncludes(...). People have added in an ad-hoc ...
7 years, 5 months ago (2013-07-24 04:22:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/19688011/1
7 years, 5 months ago (2013-07-24 04:26:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/19688011/1
7 years, 5 months ago (2013-07-24 04:28:17 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=14420
7 years, 5 months ago (2013-07-24 06:33:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/19688011/1
7 years, 5 months ago (2013-07-24 07:01:09 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=14470
7 years, 5 months ago (2013-07-24 11:01:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/19688011/1
7 years, 5 months ago (2013-07-24 11:42:54 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=14500
7 years, 5 months ago (2013-07-24 13:35:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/19688011/1
7 years, 5 months ago (2013-07-25 01:20:23 UTC) #9
commit-bot: I haz the power
7 years, 5 months ago (2013-07-25 03:06:06 UTC) #10
Message was sent while issue was closed. 
Change committed as 154890

Powered by Google App Engine
This is Rietveld 408576698