Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: Source/bindings/scripts/deprecated_code_generator_v8.pm

Issue 19688011: Code generator makes useless include line to the binding files. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org> 1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com> 2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org> 4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
5 # Copyright (C) 2006 Apple Computer, Inc. 5 # Copyright (C) 2006 Apple Computer, Inc.
6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc. 6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
8 # Copyright (C) Research In Motion Limited 2010. All rights reserved. 8 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 # Copyright (C) 2012 Ericsson AB. All rights reserved. 10 # Copyright (C) 2012 Ericsson AB. All rights reserved.
(...skipping 5450 matching lines...) Expand 10 before | Expand all | Expand 10 after
5461 if (IsRefPtrType($arrayOrSequenceType)) { 5461 if (IsRefPtrType($arrayOrSequenceType)) {
5462 AddIncludesForType($arrayOrSequenceType); 5462 AddIncludesForType($arrayOrSequenceType);
5463 } 5463 }
5464 return "${indent}v8SetReturnValue(${getCallbackInfo}, v8Array($nativeVal ue, $getIsolate));" if $isReturnValue; 5464 return "${indent}v8SetReturnValue(${getCallbackInfo}, v8Array($nativeVal ue, $getIsolate));" if $isReturnValue;
5465 return "$indent$receiver v8Array($nativeValue, $getIsolate);"; 5465 return "$indent$receiver v8Array($nativeValue, $getIsolate);";
5466 } 5466 }
5467 5467
5468 AddIncludesForType($type); 5468 AddIncludesForType($type);
5469 5469
5470 if ($type eq "SerializedScriptValue") { 5470 if ($type eq "SerializedScriptValue") {
5471 AddToImplIncludes("$type.h");
5472 my $returnValue = "$nativeValue ? $nativeValue->deserialize() : v8::Hand le<v8::Value>(v8::Null($getIsolate))"; 5471 my $returnValue = "$nativeValue ? $nativeValue->deserialize() : v8::Hand le<v8::Value>(v8::Null($getIsolate))";
5473 return "${indent}v8SetReturnValue(${getCallbackInfo}, $returnValue);" if $isReturnValue; 5472 return "${indent}v8SetReturnValue(${getCallbackInfo}, $returnValue);" if $isReturnValue;
5474 return "$indent$receiver $returnValue;"; 5473 return "$indent$receiver $returnValue;";
5475 } 5474 }
5476 5475
5477 AddToImplIncludes("wtf/RefPtr.h"); 5476 AddToImplIncludes("wtf/RefPtr.h");
5478 AddToImplIncludes("wtf/GetPtr.h"); 5477 AddToImplIncludes("wtf/GetPtr.h");
5479 5478
5480 if ($getScriptWrappable) { 5479 if ($getScriptWrappable) {
5481 # FIXME: Use safe handles 5480 # FIXME: Use safe handles
(...skipping 521 matching lines...) Expand 10 before | Expand all | Expand 10 after
6003 if ($currentInterface->extendedAttributes->{$extendedAttribute}) { 6002 if ($currentInterface->extendedAttributes->{$extendedAttribute}) {
6004 $found = 1; 6003 $found = 1;
6005 } 6004 }
6006 return 1 if $found; 6005 return 1 if $found;
6007 }, 0); 6006 }, 0);
6008 6007
6009 return $found; 6008 return $found;
6010 } 6009 }
6011 6010
6012 1; 6011 1;
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698