Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1968603003: Swap SkGpuBlurUtils over to using SkIRects (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Swap SkGpuBlurUtils over to using SkIRects We don't have to land this, but I found it more comforting for the blurring code to explicitly deal with SkIRects rather than SkRects with integer values. Split out of: https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1968603003 Committed: https://skia.googlesource.com/skia/+/f054b1766b96d270b98efd9afc87835d299d4a4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -110 lines) Patch
M include/core/SkMaskFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkScalar.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/effects/SkGpuBlurUtils.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 16 chunks +96 lines, -79 lines 0 comments Download
M src/gpu/GrBlurUtils.cpp View 8 chunks +16 lines, -19 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 7 months ago (2016-05-11 18:19:06 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968603003/1
4 years, 7 months ago (2016-05-11 18:21:15 UTC) #6
bsalomon
rubberstamp lgtm
4 years, 7 months ago (2016-05-11 18:38:15 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-11 18:50:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968603003/1
4 years, 7 months ago (2016-05-13 11:44:41 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 12:06:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f054b1766b96d270b98efd9afc87835d299d4a4e

Powered by Google App Engine
This is Rietveld 408576698