components/offline_pages.gypi - Issue 1968563003: [Offline pages] Extracting callbacks from the Offline Page Model

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages.gypi

Issue 1968563003: [Offline pages] Extracting callbacks from the Offline Page Model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/offline_pages.gypi

diff --git a/components/offline_pages.gypi b/components/offline_pages.gypi

index 8272f2d36504ce121896da7355082fd11c376a74..045aa09c697b7125a13fd0748a489ef12ed86e3d 100644

--- a/components/offline_pages.gypi

+++ b/components/offline_pages.gypi

@@ -23,9 +23,9 @@

'sources': [

'offline_pages/client_policy_controller.cc',

- 'offline_pages/client_policy_controller.h',

+ 'offline_pages/client_policy_controller.h',

msramek 2016/05/11 11:38:34 Spaces instead of tabs please :)

fgorski 2016/05/11 18:39:05 Yeah, notice that that is exactly what I was tryin

'offline_pages/offline_page_archiver.h',

- 'offline_pages/offline_page_client_policy.h',

+ 'offline_pages/offline_page_client_policy.h',

'offline_pages/offline_page_feature.cc',

'offline_pages/offline_page_feature.h',

'offline_pages/offline_page_item.cc',

@@ -36,8 +36,9 @@

'offline_pages/offline_page_metadata_store_impl.h',

'offline_pages/offline_page_model.cc',

'offline_pages/offline_page_model.h',

- 'offline_pages/offline_page_storage_manager.cc',

- 'offline_pages/offline_page_storage_manager.h',

+ 'offline_pages/offline_page_storage_manager.cc',

+ 'offline_pages/offline_page_storage_manager.h',

+ 'offline_pages/offline_page_types.h',

'offline_pages/snapshot_controller.cc',

'offline_pages/snapshot_controller.h',

'offline_pages/offline_page_metadata_store_sql.cc',

@@ -112,7 +113,7 @@

'target_name': 'offline_page_model_enums_java',

'type': 'none',

'variables': {

- 'source_file': 'offline_pages/offline_page_model.h',

+ 'source_file': 'offline_pages/offline_page_types.h',

'includes': [ '../build/android/java_cpp_enum.gypi' ],

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_remover.cc ('k') | components/offline_pages/BUILD.gn » ('j') | no next file with comments »