[Offline pages] Extracting callbacks from the Offline Page Model

components/offline_pages.gypi

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       # GN: //components/offline_pages:offline_pages
       'target_name': 'offline_pages',
       'type': 'static_library',
       'include_dirs': [
         '..',
       ],
       'dependencies': [
         '../base/base.gyp:base',
         '../net/net.gyp:net',
         '../url/url.gyp:url_lib',
         '../sql/sql.gyp:sql',
         '../third_party/leveldatabase/leveldatabase.gyp:leveldatabase',
         'components.gyp:leveldb_proto',
         'keyed_service_core',
         'offline_pages_proto',
       ],
       'sources': [
         'offline_pages/client_policy_controller.cc',
-        'offline_pages/client_policy_controller.h',
+              'offline_pages/client_policy_controller.h',

[msramek, 2016/05/11 11:38:34]

Spaces instead of tabs please :)

[fgorski, 2016/05/11 18:39:05]

Yeah, notice that that is exactly what I was trying to do... I added spaces
where they needed to be, but my IDE (hhhm VIM) didn't show me that there is
still a tab at the beginning of the line.

         'offline_pages/offline_page_archiver.h',
-        'offline_pages/offline_page_client_policy.h',
+              'offline_pages/offline_page_client_policy.h',
         'offline_pages/offline_page_feature.cc',
         'offline_pages/offline_page_feature.h',
         'offline_pages/offline_page_item.cc',
         'offline_pages/offline_page_item.h',
         'offline_pages/offline_page_metadata_store.cc',
         'offline_pages/offline_page_metadata_store.h',
         'offline_pages/offline_page_metadata_store_impl.cc',
         'offline_pages/offline_page_metadata_store_impl.h',
         'offline_pages/offline_page_model.cc',
         'offline_pages/offline_page_model.h',
-        'offline_pages/offline_page_storage_manager.cc',
-        'offline_pages/offline_page_storage_manager.h',
+              'offline_pages/offline_page_storage_manager.cc',
+              'offline_pages/offline_page_storage_manager.h',
+        'offline_pages/offline_page_types.h',
         'offline_pages/snapshot_controller.cc',
         'offline_pages/snapshot_controller.h',
         'offline_pages/offline_page_metadata_store_sql.cc',
         'offline_pages/offline_page_metadata_store_sql.h',
       ],
     },
     {
       # GN: //components/offline_pages/background:background_offliner
       'target_name': 'offline_pages_background_offliner',
       'type': 'static_library',
@@ skipping 54 matching lines @@
     },
   ],
   'conditions': [
     ['OS == "android"', {
       'targets': [
         {
           # GN: //components/offline_pages:offline_page_model_enums_java
           'target_name': 'offline_page_model_enums_java',
           'type': 'none',
           'variables': {
-            'source_file': 'offline_pages/offline_page_model.h',
+            'source_file': 'offline_pages/offline_page_types.h',
           },
           'includes': [ '../build/android/java_cpp_enum.gypi' ],
         },
       ],
     }],
   ],
 }