Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1968553002: Move absoluteRects() and absoluteQuads() overrides to LayoutBlockFlow. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
szager1, wkorman, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move absoluteRects() and absoluteQuads() overrides to LayoutBlockFlow. They only deal with continuations. BUG=302024 Committed: https://crrev.com/23c8adcd797aee7572d9d351f1c0cbe9a58d2641 Cr-Commit-Position: refs/heads/master@{#392685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -38 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-10 18:25:21 UTC) #2
eae
LGTM
4 years, 7 months ago (2016-05-10 18:35:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968553002/1
4 years, 7 months ago (2016-05-10 18:38:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 19:38:44 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 19:40:17 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/23c8adcd797aee7572d9d351f1c0cbe9a58d2641
Cr-Commit-Position: refs/heads/master@{#392685}

Powered by Google App Engine
This is Rietveld 408576698