Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 1968553002: Move absoluteRects() and absoluteQuads() overrides to LayoutBlockFlow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBlock.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
index bc46a2b38b836012f8081342507ed02f5b264f16..1e98d59464f0cb6980a68ecfff3a65a092da0f03 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
@@ -2035,41 +2035,6 @@ LayoutBlockFlow* LayoutBlock::nearestInnerBlockWithFirstLine() const
return nullptr;
}
-void LayoutBlock::absoluteRects(Vector<IntRect>& rects, const LayoutPoint& accumulatedOffset) const
-{
- // For blocks inside inlines, we go ahead and include margins so that we run right up to the
- // inline boxes above and below us (thus getting merged with them to form a single irregular
- // shape).
- if (isAnonymousBlockContinuation()) {
- // FIXME: This is wrong for vertical writing-modes.
- // https://bugs.webkit.org/show_bug.cgi?id=46781
- LayoutRect rect(accumulatedOffset, size());
- rect.expand(collapsedMarginBoxLogicalOutsets());
- rects.append(pixelSnappedIntRect(rect));
- continuation()->absoluteRects(rects, accumulatedOffset - toLayoutSize(location() +
- inlineElementContinuation()->containingBlock()->location()));
- } else {
- rects.append(pixelSnappedIntRect(accumulatedOffset, size()));
- }
-}
-
-void LayoutBlock::absoluteQuads(Vector<FloatQuad>& quads) const
-{
- // For blocks inside inlines, we go ahead and include margins so that we run right up to the
- // inline boxes above and below us (thus getting merged with them to form a single irregular
- // shape).
- if (isAnonymousBlockContinuation()) {
- // FIXME: This is wrong for vertical writing-modes.
- // https://bugs.webkit.org/show_bug.cgi?id=46781
- LayoutRect localRect(LayoutPoint(), size());
- localRect.expand(collapsedMarginBoxLogicalOutsets());
- quads.append(localToAbsoluteQuad(FloatRect(localRect)));
- continuation()->absoluteQuads(quads);
- } else {
- quads.append(LayoutBox::localToAbsoluteQuad(FloatRect(0, 0, size().width().toFloat(), size().height().toFloat())));
- }
-}
-
LayoutObject* LayoutBlock::hoverAncestor() const
{
return isAnonymousBlockContinuation() ? continuation() : LayoutBox::hoverAncestor();
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlock.h ('k') | third_party/WebKit/Source/core/layout/LayoutBlockFlow.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698