Issue 1968543003: Remove ServiceRegistry's support for exposed services.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1968543003: Remove ServiceRegistry's support for exposed services. (Closed)

Created:
4 years, 7 months ago by viettrungluu

Modified:
4 years, 7 months ago

Reviewers:
vardhan

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@work790

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove ServiceRegistry's support for exposed services. R=vardhan@google.com BUG=#762 Committed: https://chromium.googlesource.com/external/mojo/+/98fc6b388cd420e9379327f6c57efbd6acaa825e

Patch Set 1 #

Patch Set 2 : delete moar stuff #

Patch Set 3 : delete even moar stuff #

Patch Set 4 : doh #

Patch Set 5 : omg #

Patch Set 6 : foo #

Patch Set 7 : oops #

Patch Set 8 : asdf #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -37 lines)			Patch
M	mojo/public/cpp/application/lib/application_impl.cc	View	1 2	1 chunk	+6 lines, -5 lines	0 comments	Download
M	mojo/public/cpp/application/lib/service_registry.h	View	1 2 3 4 5 6 7	3 chunks	+2 lines, -15 lines	0 comments	Download
M	mojo/public/cpp/application/lib/service_registry.cc	View	1 2 3 4 5 6	3 chunks	+6 lines, -17 lines	0 comments	Download

Depends on Patchset:

Issue 1966003002 Patch 1

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

Maybe depends on https://codereview.chromium.org/1966003002/ (or maybe it doesn't -- too lazy to check).

4 years, 7 months ago (2016-05-10 20:57:42 UTC) #1

viettrungluu

4 years, 7 months ago (2016-05-10 23:02:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #8 (id:140001) manually as
98fc6b388cd420e9379327f6c57efbd6acaa825e (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages