Issue 1966003002: Remove ApplicationConnection::GetServiceProvider().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1966003002: Remove ApplicationConnection::GetServiceProvider(). (Closed)

Created:
4 years, 7 months ago by viettrungluu

Modified:
4 years, 7 months ago

Reviewers:
vardhan

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove ApplicationConnection::GetServiceProvider(). This is really only useful when there are wrong-way serivce providers. R=vardhan@google.com BUG=#762 Committed: https://chromium.googlesource.com/external/mojo/+/a9586331a33a6d2632c263d1a46174e39c78a412

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -11 lines)			Patch
M	mojo/public/cpp/application/application_connection.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	mojo/public/cpp/application/lib/service_registry.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/public/cpp/application/lib/service_registry.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	services/log/log_impl_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Dependent Patchsets:

Issue 1968543003 Patch 1

Issue 1968543003 Patch 20001

Issue 1968543003 Patch 40001

Issue 1968543003 Patch 60001

Issue 1968543003 Patch 80001

Issue 1968543003 Patch 100001

Issue 1968543003 Patch 120001

Issue 1968543003 Patch 140001

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

4 years, 7 months ago (2016-05-10 23:02:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a9586331a33a6d2632c263d1a46174e39c78a412 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages