Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1968323002: Work around is check issue causing zone error handlers to never fire. Update test expectations to r… (Closed)

Created:
4 years, 7 months ago by Jacob
Modified:
4 years, 7 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Work around is check issue causing zone error handlers to never fire. Update test expectations to reflect the correct expectations. BUG= R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/2529fc082589152bcb4992ed86d9326f89392c1b

Patch Set 1 #

Patch Set 2 : ptal #

Patch Set 3 : ptal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -10 lines) Patch
M lib/runtime/dart_sdk.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/browser/language_tests.js View 1 2 5 chunks +17 lines, -6 lines 0 comments Download
M tool/input_sdk/lib/async/zone.dart View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
4 years, 7 months ago (2016-05-12 01:33:55 UTC) #2
Leaf
lgtm
4 years, 7 months ago (2016-05-12 16:28:39 UTC) #3
Jacob
4 years, 7 months ago (2016-05-12 16:33:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
2529fc082589152bcb4992ed86d9326f89392c1b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698