Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tool/input_sdk/lib/async/zone.dart

Issue 1968323002: Work around is check issue causing zone error handlers to never fire. Update test expectations to r… (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: ptal Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/browser/language_tests.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/input_sdk/lib/async/zone.dart
diff --git a/tool/input_sdk/lib/async/zone.dart b/tool/input_sdk/lib/async/zone.dart
index 24f83f8bd8ba69a5ce7468aa031005d93a9d2266..6b13e66df92bb9ac891e71f29d9b9cbc878ea4e7 100644
--- a/tool/input_sdk/lib/async/zone.dart
+++ b/tool/input_sdk/lib/async/zone.dart
@@ -1274,8 +1274,11 @@ const _ROOT_ZONE = const _RootZone();
errorHandler = (Zone self, ZoneDelegate parent, Zone zone,
error, StackTrace stackTrace) {
try {
- if (onError is ZoneBinaryCallback<dynamic/*=R*/, dynamic, StackTrace>) {
- return self.parent.runBinary(onError, error, stackTrace);
+ // Change this is check back to
+ // onError is ZoneBinaryCallback<dynamic/*=R*/, dynamic, StackTrace>
+ // once is checks for that type are handled correctly.
+ if (onError is ZoneBinaryCallback<dynamic, dynamic, StackTrace>) {
+ return self.parent.runBinary(onError, error, stackTrace) as Object/*=R*/;
}
return self.parent.runUnary(onError, error);
} catch(e, s) {
« no previous file with comments | « test/browser/language_tests.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698