Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 19683010: Merge all Hydrogen phase declarations into hydrogen-phases.h. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Merge all Hydrogen phase declarations into hydrogen-phases.h. See https://codereview.chromium.org/18562009 for the discussion.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+417 lines, -1072 lines) Patch
M src/hydrogen.cc View 1 chunk +1 line, -17 lines 0 comments Download
D src/hydrogen-bce.h View 1 chunk +0 lines, -72 lines 0 comments Download
M src/hydrogen-bce.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/hydrogen-canonicalize.h View 1 chunk +0 lines, -51 lines 0 comments Download
M src/hydrogen-canonicalize.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/hydrogen-dce.h View 1 chunk +0 lines, -56 lines 0 comments Download
M src/hydrogen-dce.cc View 1 chunk +1 line, -2 lines 0 comments Download
D src/hydrogen-dehoist.h View 1 chunk +0 lines, -51 lines 0 comments Download
M src/hydrogen-dehoist.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/hydrogen-deoptimizing-mark.h View 1 chunk +0 lines, -56 lines 0 comments Download
M src/hydrogen-deoptimizing-mark.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/hydrogen-environment-liveness.h View 1 chunk +0 lines, -88 lines 0 comments Download
M src/hydrogen-environment-liveness.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/hydrogen-escape-analysis.h View 1 chunk +0 lines, -57 lines 0 comments Download
M src/hydrogen-escape-analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/hydrogen-gvn.h View 1 chunk +0 lines, -89 lines 0 comments Download
D src/hydrogen-infer-representation.h View 1 chunk +0 lines, -57 lines 0 comments Download
M src/hydrogen-infer-representation.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/hydrogen-infer-types.h View 1 chunk +0 lines, -59 lines 0 comments Download
M src/hydrogen-infer-types.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/hydrogen-minus-zero.h View 1 chunk +0 lines, -56 lines 0 comments Download
M src/hydrogen-minus-zero.cc View 1 chunk +1 line, -1 line 0 comments Download
A src/hydrogen-phases.h View 1 chunk +396 lines, -0 lines 0 comments Download
D src/hydrogen-range-analysis.h View 1 chunk +0 lines, -59 lines 0 comments Download
D src/hydrogen-redundant-phi.h View 1 chunk +0 lines, -53 lines 0 comments Download
D src/hydrogen-removable-simulates.h View 1 chunk +0 lines, -51 lines 0 comments Download
M src/hydrogen-removable-simulates.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/hydrogen-representation-changes.h View 1 chunk +0 lines, -55 lines 0 comments Download
D src/hydrogen-sce.h View 1 chunk +0 lines, -48 lines 0 comments Download
M src/hydrogen-sce.cc View 1 chunk +1 line, -2 lines 0 comments Download
D src/hydrogen-uint32-analysis.h View 1 chunk +0 lines, -59 lines 0 comments Download
M src/hydrogen-uint32-analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +7 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
7 years, 5 months ago (2013-07-22 06:55:34 UTC) #1
Sven Panne
Strong -1 from my side. Although this is a kind of bike shed discussion, I ...
7 years, 5 months ago (2013-07-22 07:15:04 UTC) #2
titzer
lgtm
7 years, 5 months ago (2013-07-22 07:15:04 UTC) #3
danno
7 years, 5 months ago (2013-07-22 08:00:01 UTC) #4
I tend to agree with Sven on this one. The more I think about it, the less I
like the single phase header... I see no real advantage and just a big
disadvantage--not being able to quick jump between the header and source file.

I think moving all of the compiler-related files into a hydrogen directory helps
keep a handle on the files-per-directory explosio and I'd prefer doing that
first.

Powered by Google App Engine
This is Rietveld 408576698