Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: remoting/android/java/res/menu/options_actionbar.xml

Issue 1968283002: Implementing Host List Context Menu and Delete Feature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: UI Only & Reviewer's Feedback Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/res/menu/options_actionbar.xml
diff --git a/remoting/android/java/res/menu/options_actionbar.xml b/remoting/android/java/res/menu/options_actionbar.xml
new file mode 100644
index 0000000000000000000000000000000000000000..d3801a7f9e92d1cbe1969006c00455efd22042d9
--- /dev/null
+++ b/remoting/android/java/res/menu/options_actionbar.xml
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="utf-8"?>
Lambros 2016/05/13 21:17:10 Is this related to any action-bar? Maybe name this
Yuwei 2016/05/13 23:43:54 Done. Renamed to host_context_menu.xml
+
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file.
+-->
+
+<menu xmlns:android="http://schemas.android.com/apk/res/android"
+ xmlns:app="http://schemas.android.com/apk/res-auto">
+ <item android:id="@+id/actionbar_connect"
Lambros 2016/05/13 21:17:10 host_menu_connect? (I think just 'connect' might b
Yuwei 2016/05/13 23:43:54 Renamed to connect and delete. The only concern is
+ android:title="@string/connect_button"
+ app:showAsAction="never"/>
Lambros 2016/05/13 21:17:10 Do we need to specify showAsAction for context-men
Yuwei 2016/05/13 23:43:54 Removed.
+ <item android:id="@+id/actionbar_delete"
+ android:title="@string/delete_list_item"
+ app:showAsAction="never"/>
+</menu>

Powered by Google App Engine
This is Rietveld 408576698