remoting/android/java/res/menu/options_actionbar.xml - Issue 1968283002: Implementing Host List Context Menu and Delete Feature

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/android/java/res/menu/options_actionbar.xml

Issue 1968283002: Implementing Host List Context Menu and Delete Feature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: UI Only & Reviewer's Feedback Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | remoting/android/java/src/org/chromium/chromoting/Chromoting.java » ('j') | remoting/android/java/src/org/chromium/chromoting/Chromoting.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	Lambros 2016/05/13 21:17:10 Is this related to any action-bar? Maybe name this Is this related to any action-bar? Maybe name this host_options.xml or host_context_menu.xml instead? Yuwei 2016/05/13 23:43:54 Done. Renamed to host_context_menu.xml Show quoted text On 2016/05/13 21:17:10, Lambros wrote: > Is this related to any action-bar? Maybe name this > host_options.xml or host_context_menu.xml instead? Done. Renamed to host_context_menu.xml
	2

	3 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7

	8 <menu xmlns:android="http://schemas.android.com/apk/res/android"

	9 xmlns:app="http://schemas.android.com/apk/res-auto">

	10 <item android:id="@+id/actionbar_connect"
	Lambros 2016/05/13 21:17:10 host_menu_connect? (I think just 'connect' might b host_menu_connect? (I think just 'connect' might be OK, I don't think it matters about name-collisions with other files?) Yuwei 2016/05/13 23:43:54 Renamed to connect and delete. The only concern is Show quoted text On 2016/05/13 21:17:10, Lambros wrote: > host_menu_connect? (I think just 'connect' might be OK, I don't think it matters > about name-collisions with other files?) Renamed to connect and delete. The only concern is if later we need different connect and delete context menu item for different purpose then we will need to rename something. We can think about this when we get to this point...
	11 android:title="@string/connect_button"

	12 app:showAsAction="never"/>
	Lambros 2016/05/13 21:17:10 Do we need to specify showAsAction for context-men Do we need to specify showAsAction for context-menu items? Yuwei 2016/05/13 23:43:54 Removed. Show quoted text On 2016/05/13 21:17:10, Lambros wrote: > Do we need to specify showAsAction for context-menu items? Removed.
	13 <item android:id="@+id/actionbar_delete"

	14 android:title="@string/delete_list_item"

	15 app:showAsAction="never"/>

	16 </menu>

OLD	NEW