Implementing Host List Context Menu and Delete Feature

remoting/resources/remoting_strings.grd

Index: remoting/resources/remoting_strings.grd
diff --git a/remoting/resources/remoting_strings.grd b/remoting/resources/remoting_strings.grd
index bdb1e3cdd5f2cfc2b3bb8f7ca3184dc0597c3407..212fabb697a0e713b4a3075dfcd175ecbe14eaf9 100644
--- a/remoting/resources/remoting_strings.grd
+++ b/remoting/resources/remoting_strings.grd
@@ -708,6 +708,9 @@ For information about privacy, please see the Google Privacy Policy (http://goo.
       <message desc="Confirmation prompt shown when a user attempts to delete a Me2Me host from their host list." name="IDS_CONFIRM_HOST_DELETE">
         Are you sure you want to disable remote connections to <ph name="HOSTNAME">$1<ex>My Linux desktop</ex></ph>? If you change your mind, you'll need to visit that computer to re-enable connections.
       </message>
+      <message desc="Confirmation prompt shown when a user attempts to delete a Me2Me host from their host list." name="IDS_CONFIRM_HOST_DELETE_ANDROID" formatter_data="android_java">

[Lambros, 2016/05/12 23:42:13]

Translators might not understand "Me2e" or even "host". The only context they
have is the English text and the description - they might not be familiar with
our technology.
Maybe phrase this as
"...attempts to remove or deactivate a machine from the list of their
remotely-accessible machines" ?

[Yuwei, 2016/05/13 19:09:32]

Done.

+        Disable remote access to <ph name="HOSTNAME">%1$s<ex>My Linux desktop</ex></ph>? You can only re-enable it on that computer.
+      </message>
       <message desc="Column header in the connection history table showing the email address of the client end of the connection (the initiator) which may be this or another computer." name="IDS_CONNECTION_FROM_HEADER">
         From
       </message>
@@ -726,7 +729,7 @@ For information about privacy, please see the Google Privacy Policy (http://goo.
       <message desc="Description for the client app. This is shown to the client user above the access code entry box before the connection is started. Note that the 'Share Now' quote should be copied verbatim from the corresponding translation." name="IDS_DESCRIPTION_CONNECT">
         Ask the user whose computer you wish to access to click “<ph name="SHARE">$1<ex>Share</ex></ph>” and give you the access code.
       </message>
-      <message desc="Label for the 'yes' response to the dialog asking the user to confirm whether or not they want to disable remote access to a host." name="IDS_DISABLE_HOST">
+      <message desc="Label for the 'yes' response to the dialog asking the user to confirm whether or not they want to disable remote access to a host." name="IDS_DISABLE_HOST" formatter_data="android_java">
         Disable
       </message>
       <message desc="Label for the client-side disconnect button. Clicking this button disconnects oneself from the host." name="IDS_DISCONNECT_MYSELF_BUTTON" formatter_data="android_java">
@@ -1113,7 +1116,7 @@ For information about privacy, please see the Google Privacy Policy (http://goo.
       <message desc="Link to allow a host's paired clients to be viewed or edited." name="IDS_HOME_DAEMON_MANAGE_PAIRINGS">
         View/edit
       </message>
-      <message desc="Link to delete a specific paired client." name="IDS_DELETE_PAIRED_CLIENT">
+      <message desc="Link to delete a specific paired client." name="IDS_DELETE_PAIRED_CLIENT" formatter_data="android_java">

[Yuwei, 2016/05/11 23:43:59]

I may be misusing the message given the name "IDS_DELETE_PAIRED_CLIENT"... Is it
a good idea to copy the message and name it something like IDS_DELETE_HOST?

[Lambros, 2016/05/12 23:42:13]

Given the label is just "Delete", we should probably add a new generic
"IDS_DELETE" string and deprecate IDS_DELETE_PAIRED_CLIENT.

Note that if two messages have the same text, they will not be translated
separately unless they have a "meaning" attribute
(https://www.chromium.org/developers/tools-we-use-in-chromium/grit/grit-users-...).

So you might want to add meaning="Generic Delete button" to a new IDS_DELETE
message, in case the other "Delete" message was somehow translated specifically
for paired clients (though it seems unlikely - translators probably wouldn't
know what paired clients are anyway :)  Jamie, WDYT?

[Jamie, 2016/05/13 00:45:31]

This is a pitfall of short strings: it's tough to know whether or not two
concepts which use the same string in English will be the same in all languages.
In this case, I think it's the same sense of the word "Delete" in both contexts,
so using the same string is fine, but updating the description is probably a
good idea.

[Sergey Ulanov, 2016/05/13 17:35:24]

I agree that there are cases when it may be useful to have different strings for
the same English strings used in different contexts. But unfortunately GRIT
won't handle this properly. It hashes strings by their English variants and so
'Delete' can be translated only once in each language.

         Delete
       </message>
       <message desc="Link to delete all paired clients." name="IDS_DELETE_ALL_PAIRED_CLIENTS">