Implementing Host List Context Menu and Delete Feature

remoting/resources/remoting_strings.grd

 <?xml version="1.0" encoding="UTF-8"?>
 
 <grit base_dir="." current_release="1" enc_check="möl" latest_public_release="0" source_lang_id="en">
   <outputs>
     <output filename="remoting/base/string_resources.h" type="rc_header">
       <emit emit_type="prepend"/>
     </output>
 
     <output filename="remoting/resources/am.pak" lang="am" type="data_package"/>
     <output filename="remoting/resources/ar.pak" lang="ar" type="data_package"/>
@@ skipping 690 matching lines @@
       </message>
       <message desc="Label for the connect button. Clicking this button will start the Chrome Remote Desktop session if the access code is correct." name="IDS_CONNECT_BUTTON" formatter_data="android_java">
         Connect
       </message>
       <message desc="Label for the connect button for hosts running an out-of-date version of the Me2Me host software. The user clicks this button to acknowledge the message but continue with the connection anyway." name="IDS_CONNECT_ANYWAY">
         Connect anyway
       </message>
       <message desc="Confirmation prompt shown when a user attempts to delete a Me2Me host from their host list." name="IDS_CONFIRM_HOST_DELETE">
         Are you sure you want to disable remote connections to <ph name="HOSTNAME">$1<ex>My Linux desktop</ex></ph>? If you change your mind, you'll need to visit that computer to re-enable connections.
       </message>
+      <message desc="Confirmation prompt shown when a user attempts to delete a Me2Me host from their host list." name="IDS_CONFIRM_HOST_DELETE_ANDROID" formatter_data="android_java">

[Lambros, 2016/05/12 23:42:13]

Translators might not understand "Me2e" or even "host". The only context they
have is the English text and the description - they might not be familiar with
our technology.
Maybe phrase this as
"...attempts to remove or deactivate a machine from the list of their
remotely-accessible machines" ?

[Yuwei, 2016/05/13 19:09:32]

Done.

+        Disable remote access to <ph name="HOSTNAME">%1$s<ex>My Linux desktop</ex></ph>? You can only re-enable it on that computer.
+      </message>
       <message desc="Column header in the connection history table showing the email address of the client end of the connection (the initiator) which may be this or another computer." name="IDS_CONNECTION_FROM_HEADER">
         From
       </message>
       <message desc="Title for the connection history dialog. This dialog shows recent connections made to and from this computer" name="IDS_CONNECTION_HISTORY_TITLE">
         Connection History
       </message>
       <message desc="Column header in the connection history table showing the email address of the host end of the connection (the connectee) which may be this or another computer." name="IDS_CONNECTION_TO_HEADER">
         To
       </message>
       <message desc="Label for the continue button on the pre-authorization page. Clicking this button takes the user to the standard Google Accounts authorization page." name="IDS_CONTINUE_BUTTON">
         Continue
       </message>
       <message desc="Message displayed when the session has lasted longer than five minutes, explaining that the host computer is being shared and asking whether or not the user wants to continue sharing it." name="IDS_CONTINUE_PROMPT">
         You are currently sharing this machine with another user. Do you want to continue sharing?
       </message>
       <message desc="Description for the client app. This is shown to the client user above the access code entry box before the connection is started. Note that the 'Share Now' quote should be copied verbatim from the corresponding translation." name="IDS_DESCRIPTION_CONNECT">
         Ask the user whose computer you wish to access to click “<ph name="SHARE">$1<ex>Share</ex></ph>” and give you the access code.
       </message>
-      <message desc="Label for the 'yes' response to the dialog asking the user to confirm whether or not they want to disable remote access to a host." name="IDS_DISABLE_HOST">
+      <message desc="Label for the 'yes' response to the dialog asking the user to confirm whether or not they want to disable remote access to a host." name="IDS_DISABLE_HOST" formatter_data="android_java">
         Disable
       </message>
       <message desc="Label for the client-side disconnect button. Clicking this button disconnects oneself from the host." name="IDS_DISCONNECT_MYSELF_BUTTON" formatter_data="android_java">
         Disconnect
       </message>
       <message desc="Column header in the connection history table showing the length of time for which a connection was active, if available." name="IDS_DURATION_HEADER">
         Duration
       </message>
       <message desc="Error that is shown on the client side when the host is blocking all connections due to failed authentication attempts." name="IDS_ERROR_HOST_OVERLOAD" formatter_data="android_java">
         Connections to the remote computer are temporarily blocked because somebody was trying to connect to it with invalid PIN. Please try again later.
@@ skipping 366 matching lines @@
       </message>
       <message name="IDS_HOST_STARTED" desc="The message reported to the EventLog by Chromoting Host every time it is started.">
         Host started for user: <ph name="HOST_USERNAME">%1<ex>host@email.com</ex></ph>.
       </message>
       <message name="IDS_HOST_STOPPED" desc="The message reported to the EventLog by Chromoting Host every time it is stopped.">
         Host stopped.
       </message>
       <message desc="Link to allow a host's paired clients to be viewed or edited." name="IDS_HOME_DAEMON_MANAGE_PAIRINGS">
         View/edit
       </message>
-      <message desc="Link to delete a specific paired client." name="IDS_DELETE_PAIRED_CLIENT">
+      <message desc="Link to delete a specific paired client." name="IDS_DELETE_PAIRED_CLIENT" formatter_data="android_java">

[Yuwei, 2016/05/11 23:43:59]

I may be misusing the message given the name "IDS_DELETE_PAIRED_CLIENT"... Is it
a good idea to copy the message and name it something like IDS_DELETE_HOST?

[Lambros, 2016/05/12 23:42:13]

Given the label is just "Delete", we should probably add a new generic
"IDS_DELETE" string and deprecate IDS_DELETE_PAIRED_CLIENT.

Note that if two messages have the same text, they will not be translated
separately unless they have a "meaning" attribute
(https://www.chromium.org/developers/tools-we-use-in-chromium/grit/grit-users-...).

So you might want to add meaning="Generic Delete button" to a new IDS_DELETE
message, in case the other "Delete" message was somehow translated specifically
for paired clients (though it seems unlikely - translators probably wouldn't
know what paired clients are anyway :)  Jamie, WDYT?

[Jamie, 2016/05/13 00:45:31]

This is a pitfall of short strings: it's tough to know whether or not two
concepts which use the same string in English will be the same in all languages.
In this case, I think it's the same sense of the word "Delete" in both contexts,
so using the same string is fine, but updating the description is probably a
good idea.

[Sergey Ulanov, 2016/05/13 17:35:24]

I agree that there are cases when it may be useful to have different strings for
the same English strings used in different contexts. But unfortunately GRIT
won't handle this properly. It hashes strings by their English variants and so
'Delete' can be translated only once in each language.

         Delete
       </message>
       <message desc="Link to delete all paired clients." name="IDS_DELETE_ALL_PAIRED_CLIENTS">
         Delete all
       </message>
       <message desc="Message displayed in the paired client manager dialog when all paired clients have been deleted." name="IDS_NO_PAIRED_CLIENTS">
         All paired clients have been deleted.
       </message>
       <message desc="Message displayed when the current computer has been paired with one or more clients, allowing them to connect without needing a PIN." name="IDS_HOME_DAEMON_PAIRED_MESSAGE">
         This computer is configured to allow one or more clients to connect without entering a PIN.
@@ skipping 43 matching lines @@
       <message desc="Platform-specific text indicating that a component is for the Mac OS." name="IDS_FOR_PLATFORM_MAC">
         For Mac (OS X Mavericks 10.9 and above)
       </message>
       <message desc="Text for the button the user clicks to indicate that they agree to the terms of service and want to proceed with downloading the installer." name="IDS_ACCEPT_AND_INSTALL">
         Accept and Install
       </message>
 
     </messages>
   </release>
 </grit>