Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: third_party/WebKit/LayoutTests/fast/frames/unique-name-ancestor-concatenation-conflict.html

Issue 1968213002: Try harder to make sure that blink::FrameTree::m_uniqueName is truly unique. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed CR comments from dcheng@. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/frames/unique-name-ancestor-concatenation-conflict.html
diff --git a/third_party/WebKit/LayoutTests/fast/frames/unique-name-ancestor-concatenation-conflict.html b/third_party/WebKit/LayoutTests/fast/frames/unique-name-ancestor-concatenation-conflict.html
new file mode 100644
index 0000000000000000000000000000000000000000..4347e7cb185d07202e0925833072fff765d3bccb
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/fast/frames/unique-name-ancestor-concatenation-conflict.html
@@ -0,0 +1,34 @@
+<!DOCTYPE html>
+<!--
+This test highlights that the old unique name generation algorithm
+could generate non-unique names even for static-html pages (i.e. with
+no renames and with no removal or addition of frames via DOM).
+
+This test would fail before FrameTree.cpp changes in
+https://crrev.com/1968213002.
+ -->
+<html>
+<script>
+if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.dumpChildFramesAsText();
+}
+</script>
+<body>
+
+<iframe name="foo" srcdoc="
+ <iframe name='bar' srcdoc='
+ <iframe></iframe>
+ <iframe></iframe>
+ <iframe></iframe>
+ '></iframe>
+"></iframe>
+
+<iframe name="foo/bar" srcdoc="
+ <iframe></iframe>
+ <iframe></iframe>
+ <iframe></iframe>
+"></iframe>
+
+</body>
+</html>

Powered by Google App Engine
This is Rietveld 408576698