third_party/WebKit/LayoutTests/fast/frames/unique-name-ancestor-concatenation-conflict.html - Issue 1968213002: Try harder to make sure that blink::FrameTree::m_uniqueName is truly unique.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/frames/unique-name-ancestor-concatenation-conflict.html

Issue 1968213002: Try harder to make sure that blink::FrameTree::m_uniqueName is truly unique. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR comments from dcheng@. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/frames/unique-name-all-subframes-have-same-name-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/frames/unique-name-ancestor-concatenation-conflict-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <!--

	3 This test highlights that the old unique name generation algorithm

	4 could generate non-unique names even for static-html pages (i.e. with

	5 no renames and with no removal or addition of frames via DOM).

	6

	7 This test would fail before FrameTree.cpp changes in

	8 https://crrev.com/1968213002.

	9 -->

	10 <html>

	11 <script>

	12 if (window.testRunner) {

	13 testRunner.dumpAsText();

	14 testRunner.dumpChildFramesAsText();

	15 }

	16 </script>

	17 <body>

	18

	19 <iframe name="foo" srcdoc="

	20 <iframe name='bar' srcdoc='

	21 <iframe></iframe>

	22 <iframe></iframe>

	23 <iframe></iframe>

	24 '></iframe>

	25 "></iframe>

	26

	27 <iframe name="foo/bar" srcdoc="

	28 <iframe></iframe>

	29 <iframe></iframe>

	30 <iframe></iframe>

	31 "></iframe>

	32

	33 </body>

	34 </html>

OLD	NEW