third_party/WebKit/LayoutTests/fast/frames/unique-name-ancestor-concatenation-conflict.html - Issue 1968213002: Try harder to make sure that blink::FrameTree::m_uniqueName is truly unique.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/frames/unique-name-ancestor-concatenation-conflict.html

Issue 1968213002: Try harder to make sure that blink::FrameTree::m_uniqueName is truly unique. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR comments from dcheng@. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/frames/unique-name-all-subframes-have-same-name-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/frames/unique-name-ancestor-concatenation-conflict-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/frames/unique-name-ancestor-concatenation-conflict.html

diff --git a/third_party/WebKit/LayoutTests/fast/frames/unique-name-ancestor-concatenation-conflict.html b/third_party/WebKit/LayoutTests/fast/frames/unique-name-ancestor-concatenation-conflict.html

new file mode 100644

index 0000000000000000000000000000000000000000..4347e7cb185d07202e0925833072fff765d3bccb

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/fast/frames/unique-name-ancestor-concatenation-conflict.html

@@ -0,0 +1,34 @@

+<!DOCTYPE html>

+<!--

+This test highlights that the old unique name generation algorithm

+could generate non-unique names even for static-html pages (i.e. with

+no renames and with no removal or addition of frames via DOM).

+This test would fail before FrameTree.cpp changes in

+https://crrev.com/1968213002.

+ -->

+<html>

+<script>

+if (window.testRunner) {

+ testRunner.dumpAsText();

+ testRunner.dumpChildFramesAsText();

+</script>

+<body>

+<iframe name="foo" srcdoc="

+ <iframe name='bar' srcdoc='

+ <iframe></iframe>

+ '></iframe>

+"></iframe>

+<iframe name="foo/bar" srcdoc="

+ <iframe></iframe>

+"></iframe>

+</body>

+</html>